Merge lp:~mikemc/ubuntuone-windows-installer/calling-mr-scripty into lp:ubuntuone-windows-installer

Proposed by Mike McCracken on 2012-10-17
Status: Merged
Approved by: dobey on 2012-10-30
Approved revision: 138
Merged at revision: 148
Proposed branch: lp:~mikemc/ubuntuone-windows-installer/calling-mr-scripty
Merge into: lp:ubuntuone-windows-installer
Diff against target: 34 lines (+14/-1)
1 file modified
scripts/devsetup/buildout.cfg (+14/-1)
To merge this branch: bzr merge lp:~mikemc/ubuntuone-windows-installer/calling-mr-scripty
Reviewer Review Type Date Requested Status
dobey (community) Approve on 2012-10-30
Roberto Alsina (community) 2012-10-17 Approve on 2012-10-17
Review via email: mp+130182@code.launchpad.net

Commit Message

- Use mr.scripty buildout recipe to add comtypes to development eggs only on windows.

Description of the Change

- Use mr.scripty buildout recipe to add comtypes to development eggs only on windows.

This lets us build a u1trial and u1lint that can see comtypes without breaking darwin.

Tested on darwin and windows.

TO TEST:

#darwin
% cd buildout/scripts/devsetup
% bin/buildout install u1trial
% grep "comtypes" bin/u1trial
# should show nothing

# windows
cd buildout\scripts\devsetup
bin\buildout.exe install u1trial
# whatever you want to verify that comtypes is in there

To post a comment you must log in.
Roberto Alsina (ralsina) wrote :

+1

review: Approve
dobey (dobey) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'scripts/devsetup/buildout.cfg'
2--- scripts/devsetup/buildout.cfg 2012-09-14 20:05:56 +0000
3+++ scripts/devsetup/buildout.cfg 2012-10-17 17:32:25 +0000
4@@ -48,16 +48,29 @@
5 versions = versions
6 eggs =
7 py2exe
8- comtypes
9 # Include the common [development] eggs
10 ${development:eggs}
11 interpreter = python
12
13+# using the scripty recipe to add comtypes to the development eggs
14+# only on windows. Doing this instead of putting it in the windows
15+# section because the u1lint/u1trial/etc scripts generated below
16+# shouldn't depend on the windows section.
17+[scripty]
18+recipe = mr.scripty
19+init =
20+ ... import platform
21+ ... if platform.platform().startswith('Windows'):
22+ ... self.options['eggs'] = 'comtypes'
23+ ... else:
24+ ... self.options['eggs'] = ''
25+
26 # z3c.recipe.scripts generates a python interpreter that handles the
27 # same python command line options as the real interpreter
28 [development]
29 recipe = z3c.recipe.scripts
30 eggs =
31+ ${scripty:eggs}
32 twisted
33 qt4reactor
34 python-distutils-extra

Subscribers

People subscribed via source and target branches