Merge lp:~mikemc/ubuntuone-ios-music/showing-settingsviewcontroller into lp:ubuntuone-ios-music

[Mike McCracken]

- Fix fencepost error in showing settings view when no creds are found.

- Fix fencepost error in showing settings view when no creds are found.

The issue was caused by the activate code assuming there would be 5 tab view controllers, when there was only 4, due to disabling the connection to the playlistslistviewcontroller in the storyboard.

The crash was apparently due to trying to activate a songs view controller when it was expecting creds. It was activating an arbitrary one because there were 4 view controllers and we were telling it to activate the one at index 4.

I was able to reproduce this on the iphone 6.1 simulator consistently, and this patch fixes the crash I was seeing.

[Paul Hummer (rockstar)]

review: Approve

=== modified file 'Music/UOAppDelegate.m'
--- Music/UOAppDelegate.m	2013-02-13 18:33:19 +0000
+++ Music/UOAppDelegate.m	2013-03-15 21:28:21 +0000
@@ -28,6 +28,7 @@
 //  ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH
 //  DAMAGE.
 
+#import "SettingsViewController.h"
 #import "UOAppDelegate.h"
 #import "UOAuthManager.h"
 #import "U1LocalMusicServer.h"
@@ -238,7 +239,15 @@
 - (void)checkAuthentication {
     if (![[UOAuthManager sharedAuthManager] hasCredentials]) {
         UITabBarController *rootViewController = (UITabBarController *)self.window.rootViewController;
-        rootViewController.selectedIndex = 4;
+
+        NSArray *vcs = [rootViewController viewControllers];
+        NSUInteger settings_idx = [vcs indexOfObjectPassingTest:^BOOL(id obj, NSUInteger idx, BOOL *stop) {
+            return [obj isKindOfClass:[SettingsViewController class]];
+        }];
+        
+        SettingsViewController *svc = [vcs objectAtIndex:settings_idx];
+
+        rootViewController.selectedViewController = svc;
     }
     
     [self.window makeKeyAndVisible];