Merge lp:~mikemc/ubuntuone-ios-files/delete-asset-on-main-queue into lp:ubuntuone-ios-files

Proposed by Mike McCracken
Status: Merged
Approved by: Brian Curtin
Approved revision: 79
Merged at revision: 81
Proposed branch: lp:~mikemc/ubuntuone-ios-files/delete-asset-on-main-queue
Merge into: lp:ubuntuone-ios-files
Diff against target: 14 lines (+2/-1)
1 file modified
Files/U1UploadOperation.m (+2/-1)
To merge this branch: bzr merge lp:~mikemc/ubuntuone-ios-files/delete-asset-on-main-queue
Reviewer Review Type Date Requested Status
Brian Curtin (community) Approve
dobey (community) Approve
Review via email: mp+157184@code.launchpad.net

Commit message

- delete u1asset managed object on main queue to avoid using managed objects on multiple queues

Description of the change

- delete u1asset managed object on main queue to avoid using managed objects on multiple queues

The docs say 'don't do that'

To post a comment you must log in.
79. By Mike McCracken

Poke LP to update diffs

Revision history for this message
dobey (dobey) :
review: Approve
Revision history for this message
Brian Curtin (brian.curtin) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Files/U1UploadOperation.m'
2--- Files/U1UploadOperation.m 2013-03-29 22:48:22 +0000
3+++ Files/U1UploadOperation.m 2013-04-04 18:13:24 +0000
4@@ -104,8 +104,9 @@
5 {
6 self.error = magicUploadError;
7 // Asset is gone, delete U1Asset and potentially the Node, and stop running
8+ // do this on the main context because self.fileNode was fetched there.
9 U1DataRepository *dataRepository = [U1DataRepository sharedDataRepository];
10- [dataRepository dispatchAsyncBlockWithManagedObjectContext:^(NSManagedObjectContext *context) {
11+ [dataRepository dispatchBlockWithMainContext:^(NSManagedObjectContext *context) {
12 U1Asset *assetToBeDeleted = self.fileNode.asset;
13 [context deleteObject:assetToBeDeleted];
14 if (self.fileNode.generation == nil)

Subscribers

People subscribed via source and target branches