ubuntuone-credentials

Merge lp:~mikemc/ubuntuone-credentials/validate-email into lp:ubuntuone-credentials

  1. validate-email
  2. Merge into trunk
Proposed by Mike McCracken
Status: Merged
Approved by: Alejandro J. Cura
Approved revision: 53
Merged at revision: 53
Proposed branch: lp:~mikemc/ubuntuone-credentials/validate-email
Merge into: lp:ubuntuone-credentials
Diff against target: 11 lines (+1/-0)
1 file modified
online-accounts-provider/NewAccount.qml (+1/-0)
To merge this branch: bzr merge lp:~mikemc/ubuntuone-credentials/validate-email
Reviewer Review Type Date Requested Status
Alejandro J. Cura (community) Approve
Roberto Alsina (community) Approve
Review via email: mp+183750@code.launchpad.net

Commit message

- Re-add a regexp validator to the email textfield.

Description of the change

- Re-add a regexp validator to the email textfield.

The validation function already expects this: validateInput() checks emailTextField.acceptableInput.
The validator itself was lost somehow in moving this file from the standalone QML component into the provider plugin.

To post a comment you must log in.
Revision history for this message
Roberto Alsina (ralsina) :
review: Approve
Revision history for this message
Alejandro J. Cura (alecu) wrote :

trivial, +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'online-accounts-provider/NewAccount.qml'
2--- online-accounts-provider/NewAccount.qml 2013-08-22 21:32:30 +0000
3+++ online-accounts-provider/NewAccount.qml 2013-09-03 19:23:38 +0000
4@@ -85,6 +85,7 @@
5 width: main.width - (2 * main.anchors.margins)
6 anchors.left: parent.left
7 anchors.margins: parent.anchors.margins
8+ validator: RegExpValidator { regExp: /.+@.+/ }
9 }
10
11 Row {

Subscribers

People subscribed via source and target branches

to all changes: