Merge lp:~mikemc/ubuntuone-credentials/switch-from-2fa into lp:ubuntuone-credentials

Proposed by Mike McCracken
Status: Merged
Approved by: dobey
Approved revision: 61
Merged at revision: 63
Proposed branch: lp:~mikemc/ubuntuone-credentials/switch-from-2fa
Merge into: lp:ubuntuone-credentials
Diff against target: 12 lines (+1/-1)
1 file modified
online-accounts-provider/NewAccount.qml (+1/-1)
To merge this branch: bzr merge lp:~mikemc/ubuntuone-credentials/switch-from-2fa
Reviewer Review Type Date Requested Status
Roberto Alsina (community) Approve
dobey (community) Approve
Review via email: mp+185575@code.launchpad.net

Commit message

- Properly handle switching to the register screen after logging in partially with a 2fa account.

Description of the change

- Properly handle switching to the register screen after logging in partially with a 2fa account.

Probably no one will ever try this but it ought to work anyway.

PS, this doesn't depend on the fix-tabloop branch but I did test with that branch merged in, and the tab loop still works after you switch.

TO TEST ON SAUCY desktop:
sudo apt-get build-dep ubuntuone-credentials
sudo apt-get install ubuntu-system-settings
branch this , cd into it
mkdir build
cmake -DLIB_SUFFIX=/i386-linux-gnu -DCMAKE_INSTALL_PREFIX=/usr ..
sudo make install

- run /usr/bin/system-settings
- click on "accounts":
 IF you see a list of existing accounts, click on "Add account" at the bottom, then "Ubuntu One".
 IF you see a screen saying "no accounts", click on "Ubuntu One" in the list below.

- log in with an account that requires 2fa.
- wait for the 2fa box to show
- click on the "I am a new Ubuntu One User" switch

You should now see the register UI and be able to register a new account.

To post a comment you must log in.
Revision history for this message
dobey (dobey) :
review: Approve
Revision history for this message
Roberto Alsina (ralsina) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'online-accounts-provider/NewAccount.qml'
2--- online-accounts-provider/NewAccount.qml 2013-09-13 18:31:34 +0000
3+++ online-accounts-provider/NewAccount.qml 2013-09-13 19:17:45 +0000
4@@ -171,7 +171,7 @@
5 }
6
7 function toggleNewUser() {
8- if(state == "login") {
9+ if(state == "login" || state == "twofactor") {
10 switchTo(registerForm)
11 state = "register";
12 registerForm.nameTextField.focus = true;

Subscribers

People subscribed via source and target branches

to all changes: