lp:~mikemc/ubuntuone-credentials/slot-and-signal-improvements
Created by
Mike McCracken
and last modified
- Get this branch:
- bzr branch lp:~mikemc/ubuntuone-credentials/slot-and-signal-improvements
Only
Mike McCracken
can upload to this branch. If you are
Mike McCracken
please log in for upload directions.
Branch merges
Propose for merging
No branches
dependent on this one.
- dobey (community): Approve
-
Diff: 174 lines (+40/-25)6 files modifiedlibubuntuoneauth/identityprovider.cpp (+9/-8)
libubuntuoneauth/keyring.cpp (+1/-1)
libubuntuoneauth/ssoservice.cpp (+20/-7)
libubuntuoneauth/ssoservice.h (+6/-5)
music-login/ssowizard.cpp (+3/-3)
music-login/ssowizard.h (+1/-1)
Branch information
Recent revisions
- 30. By Mike McCracken
-
- connect credentialsNotFound signal
- change credentialsStored signal to include token, and do not clear _pendingPing until after tokenStored signal, so clients can access new tokens created by login/register as well as old ones found in keyring
- rename slots to be clearer what they are connected to and avoid needing to use lots of synonyms - 29. By Mike McCracken
-
Improve logging.
- Logging before emitting a signal makes control flow clearer
- Don't add strings, just chain them with <<, avoids weird truncation. - 26. By Mike McCracken
-
Simplify source layout: Remove sso_api subdirectory so headers are all in one place, as installed.
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp:ubuntuone-credentials