Merge lp:~mikemc/ubuntuone-credentials/improve-fontsize-spacing into lp:ubuntuone-credentials

Proposed by Mike McCracken
Status: Merged
Approved by: Mike McCracken
Approved revision: 56
Merged at revision: 56
Proposed branch: lp:~mikemc/ubuntuone-credentials/improve-fontsize-spacing
Merge into: lp:ubuntuone-credentials
Prerequisite: lp:~mikemc/ubuntuone-credentials/return-of-buttons
Diff against target: 109 lines (+4/-13)
3 files modified
online-accounts-provider/LoginForm.qml (+0/-4)
online-accounts-provider/NewAccount.qml (+4/-7)
online-accounts-provider/RegisterForm.qml (+0/-2)
To merge this branch: bzr merge lp:~mikemc/ubuntuone-credentials/improve-fontsize-spacing
Reviewer Review Type Date Requested Status
Roberto Alsina (community) Approve
Review via email: mp+183759@code.launchpad.net

Commit message

- Fix spacing and margins of login/register UI. Use default fontSizes pending design input.

Description of the change

- Fix spacing and margins of login/register UI. Use default fontSizes pending design input.

To post a comment you must log in.
Revision history for this message
Roberto Alsina (ralsina) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'online-accounts-provider/LoginForm.qml'
2--- online-accounts-provider/LoginForm.qml 2013-09-03 20:38:59 +0000
3+++ online-accounts-provider/LoginForm.qml 2013-09-03 20:38:59 +0000
4@@ -18,7 +18,6 @@
5
6 Label {
7 text: "I am a returning user and my password is:"
8- fontSize: "small"
9 }
10 TextField {
11 id: passwordTextField
12@@ -33,7 +32,6 @@
13 Label {
14 text: '<a href="https://login.ubuntu.com/+forgot_password"><span style="color: #dd4814;">Forgotten your password?</span></a>'
15 textFormat: Text.RichText
16- fontSize: "small"
17 onLinkActivated: { Qt.openUrlExternally(link); }
18 }
19
20@@ -53,7 +51,6 @@
21
22 Label {
23 text: "Type your verification code:"
24- fontSize: "small"
25 }
26
27 TextField {
28@@ -70,7 +67,6 @@
29 Label {
30 text: '<a href="https://login.ubuntu.com/+device-help"><span style="color: #dd4814;">Authentication Device Help</span></a>'
31 textFormat: Text.RichText
32- fontSize: "small"
33 onLinkActivated: { Qt.openUrlExternally(link); }
34 }
35
36
37=== modified file 'online-accounts-provider/NewAccount.qml'
38--- online-accounts-provider/NewAccount.qml 2013-08-22 21:32:30 +0000
39+++ online-accounts-provider/NewAccount.qml 2013-09-03 20:38:59 +0000
40@@ -24,12 +24,8 @@
41 Column {
42 id: main
43
44- //property variant authenticationParameters: null
45-
46 property bool isNewAccount: false
47 property variant __account: account
48-// unneeded:? property alias globalAccountService: globalAccountSettings
49-
50
51 state: "login" // or "register" or "twofactor"
52 property var currentVisible: loginForm
53@@ -37,8 +33,12 @@
54
55 signal finished
56
57+ anchors.top: parent.top
58 anchors.left: parent.left
59 anchors.right: parent.right
60+ anchors.margins: units.gu(1)
61+
62+ spacing: units.gu(2)
63
64 Component.onCompleted: {
65 isNewAccount = (account.accountId === 0);
66@@ -48,7 +48,6 @@
67 Label {
68 id: title
69 text: "One account to log in to everything on Ubuntu"
70- fontSize: "medium"
71 color: UbuntuColors.coolGrey
72 anchors.left: parent.left
73 anchors.right: parent.right
74@@ -70,7 +69,6 @@
75
76 Label {
77 text: "Please type your email:"
78- fontSize: "large"
79
80 anchors.left: parent.left
81 anchors.right: parent.right
82@@ -100,7 +98,6 @@
83 Label {
84 anchors.verticalCenter: newUserToggleSwitch.verticalCenter
85 text: "I am a new Ubuntu One user"
86- fontSize: "large"
87 }
88 anchors.left: parent.left
89 anchors.right: parent.right
90
91=== modified file 'online-accounts-provider/RegisterForm.qml'
92--- online-accounts-provider/RegisterForm.qml 2013-09-03 20:38:59 +0000
93+++ online-accounts-provider/RegisterForm.qml 2013-09-03 20:38:59 +0000
94@@ -18,7 +18,6 @@
95
96 Label {
97 id: subtitle
98- fontSize: "small"
99 text: "Please tell us your name and choose a password."
100 }
101
102@@ -51,7 +50,6 @@
103 Label {
104 anchors.verticalCenter: termsAndConditionsCheckBox.verticalCenter
105 text: "I agree to the <a href='http://one.ubuntu.com/terms/'>Ubuntu One Terms and Conditions</a>"
106- fontSize: "small"
107 onLinkActivated: { Qt.openUrlExternally(link); }
108 }
109 }

Subscribers

People subscribed via source and target branches

to all changes: