Merge lp:~mikemc/ubuntuone-credentials/hide-keyboard-on-click into lp:ubuntuone-credentials

Proposed by Mike McCracken
Status: Merged
Approved by: dobey
Approved revision: 67
Merged at revision: 68
Proposed branch: lp:~mikemc/ubuntuone-credentials/hide-keyboard-on-click
Merge into: lp:ubuntuone-credentials
Diff against target: 11 lines (+1/-0)
1 file modified
online-accounts-provider/NewAccount.qml (+1/-0)
To merge this branch: bzr merge lp:~mikemc/ubuntuone-credentials/hide-keyboard-on-click
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
dobey (community) Approve
Review via email: mp+189377@code.launchpad.net

Commit message

- Hide keyboard when user submits form, making error message visible. (LP: #1231580)

Description of the change

- Hide keyboard when user submits form, making error message visible. (LP: #1231580)

Requires testing on device.

bzr branch lp:~mikemc/ubuntuone-credentials/add-input-hints
cd add-input-hints
mkdir build
cd build
cmake -DLIB_SUFFIX=/arm-linux-gnueabihf/ -DCMAKE_INSTALL_PREFIX=/usr/ ..

# then just 'build & install' the qml
cd online-accounts-provider
make
sudo make install

Then run system-settings, click "accounts", add a new U1 account with an invalid email.
scroll down as far as possible.
Click 'continue', note that the keyboard goes away and the red error label should be visible.

To post a comment you must log in.
Revision history for this message
dobey (dobey) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'online-accounts-provider/NewAccount.qml'
2--- online-accounts-provider/NewAccount.qml 2013-10-04 15:19:49 +0000
3+++ online-accounts-provider/NewAccount.qml 2013-10-04 16:58:18 +0000
4@@ -200,6 +200,7 @@
5 immediately.
6 */
7 function processForm() {
8+ Qt.inputMethod.hide();
9 loadingOverlay.visible = true;
10 formSubmitTimer.running = true;
11 }

Subscribers

People subscribed via source and target branches

to all changes: