Merge lp:~mikemc/ubuntuone-credentials/add-qmltypes into lp:ubuntuone-credentials

Proposed by Mike McCracken
Status: Merged
Approved by: Mike McCracken
Approved revision: 61
Merged at revision: 41
Proposed branch: lp:~mikemc/ubuntuone-credentials/add-qmltypes
Merge into: lp:ubuntuone-credentials
Prerequisite: lp:~mikemc/ubuntuone-credentials/ui-validation
Diff against target: 61 lines (+11/-8)
4 files modified
CMakeLists.txt (+1/-1)
qml-credentials-service/CMakeLists.txt (+5/-3)
qml-credentials-service/README (+4/-3)
qml-credentials-service/qmldir.template (+1/-1)
To merge this branch: bzr merge lp:~mikemc/ubuntuone-credentials/add-qmltypes
Reviewer Review Type Date Requested Status
Manuel de la Peña (community) Approve
dobey (community) Approve
Review via email: mp+175702@code.launchpad.net

Commit message

- add cmake rule to generate qmltypes file for qtcreator integration

Description of the change

- add cmake rule to generate qmltypes file for qtcreator integration

NOTE: the full component directory and the qmltypes file are not generated during build, only during 'make install'.

To post a comment you must log in.
58. By Mike McCracken

Merged ui-validation into add-qmltypes.

59. By Mike McCracken

merge with ui-validation, resolve conflict

Revision history for this message
dobey (dobey) wrote :

We should probably refactor this later to not do this prior to the install step.

review: Approve
60. By Mike McCracken

update README to discuss qmltypes

61. By Mike McCracken

Merged ui-validation into add-qmltypes.

Revision history for this message
Manuel de la Peña (mandel) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CMakeLists.txt'
2--- CMakeLists.txt 2013-07-11 22:38:15 +0000
3+++ CMakeLists.txt 2013-07-29 20:40:33 +0000
4@@ -28,7 +28,7 @@
5 SET (LIB_SUFFIX "" CACHE STRING "Define suffix of library directory name.")
6 SET (LIB_INSTALL_DIR "lib${LIB_SUFFIX}")
7
8-set (QML_MODULE_INSTALL_DIR ${LIB_INSTALL_DIR}/qt5/qml/${QML_MODULE_NAME} )
9+set (QML_MODULE_INSTALL_DIR ${LIB_INSTALL_DIR}/qt5/qml )
10
11 include_directories(${CMAKE_SOURCE_DIR}/libubuntuoneauth
12 ${CMAKE_SOURCE_DIR}/libubuntuoneauthui)
13
14=== modified file 'qml-credentials-service/CMakeLists.txt'
15--- qml-credentials-service/CMakeLists.txt 2013-07-19 20:22:51 +0000
16+++ qml-credentials-service/CMakeLists.txt 2013-07-29 20:40:33 +0000
17@@ -16,11 +16,13 @@
18 ${AUTH_LIB_NAME}
19 )
20
21-install (FILES ${CMAKE_CURRENT_BINARY_DIR}/qmldir DESTINATION ${QML_MODULE_INSTALL_DIR})
22+install (FILES ${CMAKE_CURRENT_BINARY_DIR}/qmldir DESTINATION ${QML_MODULE_INSTALL_DIR}/${QML_MODULE_NAME} )
23
24 install (TARGETS ${PLUGIN_NAME}
25- LIBRARY DESTINATION ${QML_MODULE_INSTALL_DIR}
26+ LIBRARY DESTINATION ${QML_MODULE_INSTALL_DIR}/${QML_MODULE_NAME}
27 NAMELINK_SKIP
28 )
29
30-install (FILES ${QML_SOURCES} DESTINATION ${QML_MODULE_INSTALL_DIR})
31+install (FILES ${QML_SOURCES} DESTINATION ${QML_MODULE_INSTALL_DIR}/${QML_MODULE_NAME} )
32+
33+install (CODE "execute_process(COMMAND qmlplugindump ${QML_MODULE_NAME} ${PLUGIN_API_VERSION} ${CMAKE_INSTALL_PREFIX}/${QML_MODULE_INSTALL_DIR} OUTPUT_FILE ${CMAKE_INSTALL_PREFIX}/${QML_MODULE_INSTALL_DIR}/${QML_MODULE_NAME}/${QML_MODULE_NAME}.qmltypes)")
34
35=== modified file 'qml-credentials-service/README'
36--- qml-credentials-service/README 2013-07-12 16:20:57 +0000
37+++ qml-credentials-service/README 2013-07-29 20:40:33 +0000
38@@ -10,9 +10,10 @@
39
40 An example for embedding the UI provided by the plugin is in examples/embedding.qml
41
42-The CMake setup only builds the complete QML component at install, so
43-to test without installing to a system location, you will need to do
44-something like the following:
45+The CMake setup only builds the complete QML component at install, and
46+the qmltypes file required by qtcreator is also only built at install,
47+so to test without installing to a system location, you will need to
48+do something like the following:
49
50 mkdir -p build
51 cd build
52
53=== modified file 'qml-credentials-service/qmldir.template'
54--- qml-credentials-service/qmldir.template 2013-07-05 17:53:27 +0000
55+++ qml-credentials-service/qmldir.template 2013-07-29 20:40:33 +0000
56@@ -1,4 +1,4 @@
57 module @QML_MODULE_NAME@
58 plugin @PLUGIN_NAME@
59 CredentialsUI 1.0 CredentialsUI.qml
60-typeinfo UbuntuOneCredentials.qmltypes
61+typeinfo @QML_MODULE_NAME@.qmltypes

Subscribers

People subscribed via source and target branches

to all changes: