Merge lp:~mikemc/ubuntuone-credentials/add-input-hints into lp:ubuntuone-credentials

[Mike McCracken]

- Use email-specific keyboard layout and avoid storing passwords in predictive input dictionary (LP: #1235282)

- Use email-specific keyboard layout and avoid storing passwords in predictive input dictionary (LP: #1235282)

Requires testing on device.

bzr branch lp:~mikemc/ubuntuone-credentials/add-input-hints
cd add-input-hints
mkdir build
cd build
cmake -DLIB_SUFFIX=/arm-linux-gnueabihf/ -DCMAKE_INSTALL_PREFIX=/usr/ ..
make
sudo make install

Then run system-settings, click "accounts", add a new U1 account and note the keyboard layout used for the email field. It should have an '@' sign next to the space bar.

I'm not aware of a way to test the sensitiveData flag.

[Roberto Alsina (ralsina)]

review: Approve

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:67
http://jenkins.qa.ubuntu.com/job/ubuntuone-credentials-ci/9/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntuone-credentials-saucy-amd64-manual/7

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntuone-credentials-ci/9/rebuild

review: Approve (continuous-integration)

[dobey (dobey)]

review: Approve

=== modified file 'online-accounts-provider/LoginForm.qml'
--- online-accounts-provider/LoginForm.qml	2013-09-24 20:26:26 +0000
+++ online-accounts-provider/LoginForm.qml	2013-10-04 16:24:11 +0000
@@ -27,6 +27,7 @@
         Keys.onReturnPressed: main.processForm();
         KeyNavigation.tab: twoFactorUI.visible ? twoFactorTextField : emailTextField /* from main */
         KeyNavigation.backtab: emailTextField /* from main */
+        inputMethodHints: Qt.ImhSensitiveData
     }
 
     Label {

=== modified file 'online-accounts-provider/NewAccount.qml'
--- online-accounts-provider/NewAccount.qml	2013-09-24 20:26:26 +0000
+++ online-accounts-provider/NewAccount.qml	2013-10-04 16:24:11 +0000
@@ -85,6 +85,7 @@
         focus: true
         KeyNavigation.tab: loginForm.visible ? loginForm.passwordTextField : registerForm.nameTextField
         KeyNavigation.backtab: loginForm.visible ? ( loginForm.twoFactorVisible ? loginForm.twoFactorTextField : loginForm.passwordTextField) : registerForm.confirmPasswordTextField
+        inputMethodHints: Qt.ImhEmailCharactersOnly
     }
 
     Row {

=== modified file 'online-accounts-provider/RegisterForm.qml'
--- online-accounts-provider/RegisterForm.qml	2013-09-24 20:26:26 +0000
+++ online-accounts-provider/RegisterForm.qml	2013-10-04 16:24:11 +0000
@@ -34,6 +34,7 @@
         width: main.width - (2 * main.anchors.margins)
         KeyNavigation.tab: confirmPasswordTextField
         KeyNavigation.backtab: nameTextField
+        inputMethodHints: Qt.ImhSensitiveData
     }
 
     TextField {
@@ -44,6 +45,7 @@
         width: main.width - (2 * main.anchors.margins)
         KeyNavigation.tab: emailTextField /* from main */
         KeyNavigation.backtab: passwordTextField
+        inputMethodHints: Qt.ImhSensitiveData
     }
 
     Row {