lp:~mikemc/ubuntuone-control-panel/fix-cloud-computer-page

Branch merges

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

357. By Mike McCracken on 2012-09-21

Connect files service after credentials are received in wizard.

Details:

CloudToComputer page uses folders.py RemoteFoldersPanel, which calls
backend.py volumes_info() with refresh=True. Setting refresh=True
means it'll call sd_client.refresh_volumes(), which eventually calls
interaction_interfaces.py refresh_volumes(), which calls
volume_manager.py refresh_volumes(), which calls action_queue.py
list_volumes(), which queues a ListVolumes class, which gets stuck
because the queue is inactive, and won't get re-enabled until we are
done with the wizard, which triggers on_wizard_finished() in
controlpanel.py, which calls on_credentials_found() and that'll start
the queue, but by then it's too late.

The fix is to call backend.connect_files() in wizard.py
_process_credentials(), so that the queue is active when we load the
CloudToComputerPage. To work, this has to actually connect, so it
ignores the autoconnect setting, which I assert is OK because we
probably don't get to this page with non-default settings, and
autoconnect is on by default.

So, how does the folders tab in the main management UI work when
autoconnect is False? If the main control panel found creds, then
it'll check autoconnect and if it's false, it doesn't call
backend.connect_files(). It just goes ahead and shows the folders tab
However, the folders tab calls backend.volumes_info() with
refresh=False, so none of that stuff above happens, and it doesn't
matter what state the queue is in (hence it doesn't matter if
autoconnect is enabled or not, the folders tab will still work).

356. By Mike McCracken on 2012-09-06

- Fix sync indicator in control panel main window. (LP: #1044197)

355. By Roberto Alsina on 2012-08-30

- Made --with-icon the default on Darwin

354. By Roberto Alsina on 2012-08-30

- Disabled search box until it's ready to work (Fixes LP: 1042885)

353. By Mike McCracken on 2012-08-30

- Fix race in backend get_credentials call. (LP: #1042860)

352. By Diego Sarmentero on 2012-08-28

- Adding functionality to the Share Links Tab (LP: #1039142).

351. By Roberto Alsina on 2012-08-27

- Fixed saving/restoring the speed throttling (Fixes LP:1040899)

350. By Roberto Alsina on 2012-08-25

- Switched to non-native dialog on darwin (LP:1040905).

349. By Roberto Alsina on 2012-08-24

- Fixed share/UDF list scrolling on Mac (LP:1018918)

348. By Manuel de la Peña on 2012-08-23

- Fixed the tab aligment by asserting that tabs are on the left via the qss (LP: #1019224).