Merge lp:~mikemc/ubuntuone-control-panel/fix-1012887-controlpanel-darwin into lp:ubuntuone-control-panel

Proposed by Mike McCracken on 2012-06-15
Status: Merged
Approved by: Roberto Alsina on 2012-06-15
Approved revision: 335
Merged at revision: 332
Proposed branch: lp:~mikemc/ubuntuone-control-panel/fix-1012887-controlpanel-darwin
Merge into: lp:ubuntuone-control-panel
Diff against target: 34 lines (+6/-6)
2 files modified
ubuntuone/controlpanel/gui/qt/main/__init__.py (+5/-5)
ubuntuone/controlpanel/gui/qt/main/twisted_main.py (+1/-1)
To merge this branch: bzr merge lp:~mikemc/ubuntuone-control-panel/fix-1012887-controlpanel-darwin
Reviewer Review Type Date Requested Status
Alejandro J. Cura (community) 2012-06-15 Approve on 2012-06-15
Review via email: mp+110637@code.launchpad.net

Commit Message

- use twisted reactor main loop on darwin as on windows (lp:1012887)

Description of the Change

- use twisted reactor main loop on darwin as on windows (lp:1012887)

also renames modules because darwin and windows both use the former 'windows.py'.

To post a comment you must log in.
334. By Mike McCracken on 2012-06-15

cleanup branch: remove call to raise_(), saved for another branch

335. By Mike McCracken on 2012-06-15

finish cleanup of raise_ changes

Alejandro J. Cura (alecu) wrote :

+1, tests pass on linux

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ubuntuone/controlpanel/gui/qt/main/__init__.py'
2--- ubuntuone/controlpanel/gui/qt/main/__init__.py 2012-05-14 22:27:07 +0000
3+++ ubuntuone/controlpanel/gui/qt/main/__init__.py 2012-06-15 22:26:18 +0000
4@@ -29,12 +29,12 @@
5 from ubuntuone.controlpanel.gui.qt.uniqueapp import UniqueApplication
6
7 # Invalid name "source", pylint: disable=C0103
8-if sys.platform == 'win32':
9- from ubuntuone.controlpanel.gui.qt.main import windows
10- source = windows
11+if sys.platform in ('win32', 'darwin'):
12+ from ubuntuone.controlpanel.gui.qt.main import twisted_main
13+ source = twisted_main
14 else:
15- from ubuntuone.controlpanel.gui.qt.main import linux
16- source = linux
17+ from ubuntuone.controlpanel.gui.qt.main import dbus_main
18+ source = dbus_main
19 # pylint: enable=C0103
20
21
22
23=== renamed file 'ubuntuone/controlpanel/gui/qt/main/linux.py' => 'ubuntuone/controlpanel/gui/qt/main/dbus_main.py'
24=== renamed file 'ubuntuone/controlpanel/gui/qt/main/windows.py' => 'ubuntuone/controlpanel/gui/qt/main/twisted_main.py'
25--- ubuntuone/controlpanel/gui/qt/main/windows.py 2012-04-05 14:52:55 +0000
26+++ ubuntuone/controlpanel/gui/qt/main/twisted_main.py 2012-06-15 22:26:18 +0000
27@@ -14,7 +14,7 @@
28 # You should have received a copy of the GNU General Public License along
29 # with this program. If not, see <http://www.gnu.org/licenses/>.
30
31-"""Main method to be used on windows."""
32+"""Main method to be used on platforms without dbus."""
33
34 from PyQt4 import QtGui
35

Subscribers

People subscribed via source and target branches