Merge lp:~mikemc/ubuntuone-client/fix-default-fs-monitor into lp:ubuntuone-client

Proposed by Mike McCracken
Status: Merged
Approved by: Diego Sarmentero
Approved revision: 1316
Merged at revision: 1324
Proposed branch: lp:~mikemc/ubuntuone-client/fix-default-fs-monitor
Merge into: lp:ubuntuone-client
Diff against target: 14 lines (+2/-2)
1 file modified
ubuntuone/platform/filesystem_notifications/monitor/__init__.py (+2/-2)
To merge this branch: bzr merge lp:~mikemc/ubuntuone-client/fix-default-fs-monitor
Reviewer Review Type Date Requested Status
Diego Sarmentero (community) Approve
Roberto Alsina (community) Approve
Review via email: mp+125291@code.launchpad.net

Commit message

- Make fsevents root daemon the default fs monitor for darwin, leave other platforms alone.

Description of the change

- Make fsevents root daemon the default fs monitor for darwin, leave other platforms alone.

In the correct way this time, by naming it 'default' and naming the other one something else, and leaving the syncdaemon.conf alone, so it won't break other platforms.

For completeness, I note that I did it the wrong way previously, in this branch: lp:~mikemc/ubuntuone-client/fsevents-daemon-default

To post a comment you must log in.
Revision history for this message
Roberto Alsina (ralsina) wrote :

+1 checked that it doesn't break ubuntu

review: Approve
Revision history for this message
Diego Sarmentero (diegosarmentero) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ubuntuone/platform/filesystem_notifications/monitor/__init__.py'
2--- ubuntuone/platform/filesystem_notifications/monitor/__init__.py 2012-08-28 07:58:50 +0000
3+++ ubuntuone/platform/filesystem_notifications/monitor/__init__.py 2012-09-19 17:44:12 +0000
4@@ -60,8 +60,8 @@
5 )
6
7 FILEMONITOR_IDS = {
8- DEFAULT_MONITOR: common.FilesystemMonitor,
9- 'daemon': darwin.fsevents_daemon.FilesystemMonitor,
10+ DEFAULT_MONITOR: darwin.fsevents_daemon.FilesystemMonitor,
11+ 'macfsevents': common.FilesystemMonitor,
12 }
13 ACTIONS = darwin.fsevents_client.ACTIONS
14 else:

Subscribers

People subscribed via source and target branches