Merge lp:~mikemc/ubuntuone-client/fix-1013261-darwins-got-credentials into lp:ubuntuone-client
Proposed by
Mike McCracken
on 2012-06-14
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Diego Sarmentero on 2012-06-15 | ||||
| Approved revision: | 1258 | ||||
| Merged at revision: | 1258 | ||||
| Proposed branch: | lp:~mikemc/ubuntuone-client/fix-1013261-darwins-got-credentials | ||||
| Merge into: | lp:ubuntuone-client | ||||
| Diff against target: |
50 lines (+7/-7) 3 files modified
tests/platform/credentials/test_ipc_service.py (+1/-1) tests/platform/credentials/test_linux.py (+1/-1) ubuntuone/platform/credentials/__init__.py (+5/-5) |
||||
| To merge this branch: | bzr merge lp:~mikemc/ubuntuone-client/fix-1013261-darwins-got-credentials | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Diego Sarmentero (community) | 2012-06-14 | Approve on 2012-06-15 | |
| Manuel de la Peña (community) | Approve on 2012-06-15 | ||
|
Review via email:
|
|||
Commit Message
- use correct IPC mechanism on darwin for credentials (lp:1013268)
Description of the Change
- use correct IPC mechanism on darwin for credentials (lp:1013268)
Also rename some modules because darwin and windows use the same ipc.
all tests pass on linux.
on macos and windows, only a subset of tests run*, but the relevant ones pass:
mac: ./run-mac-tests tests/platform/
windows: u1trial --reactor=twisted -c -p tests\platform\
To post a comment you must log in.
review:
Approve


+1