Merge lp:~mikemc/ubuntuone-client/fix-1013261-darwins-got-credentials into lp:ubuntuone-client

Proposed by Mike McCracken on 2012-06-14
Status: Merged
Approved by: Diego Sarmentero on 2012-06-15
Approved revision: 1258
Merged at revision: 1258
Proposed branch: lp:~mikemc/ubuntuone-client/fix-1013261-darwins-got-credentials
Merge into: lp:ubuntuone-client
Diff against target: 50 lines (+7/-7)
3 files modified
tests/platform/credentials/test_ipc_service.py (+1/-1)
tests/platform/credentials/test_linux.py (+1/-1)
ubuntuone/platform/credentials/__init__.py (+5/-5)
To merge this branch: bzr merge lp:~mikemc/ubuntuone-client/fix-1013261-darwins-got-credentials
Reviewer Review Type Date Requested Status
Diego Sarmentero (community) 2012-06-14 Approve on 2012-06-15
Manuel de la Peña (community) Approve on 2012-06-15
Review via email: mp+110431@code.launchpad.net

Commit Message

- use correct IPC mechanism on darwin for credentials (lp:1013268)

Description of the Change

- use correct IPC mechanism on darwin for credentials (lp:1013268)

Also rename some modules because darwin and windows use the same ipc.

all tests pass on linux.
on macos and windows, only a subset of tests run*, but the relevant ones pass:

mac: ./run-mac-tests tests/platform/credentials
windows: u1trial --reactor=twisted -c -p tests\platform\linux -i "test_linux.py,test_darwin.py" tests\platform

To post a comment you must log in.
review: Approve
Diego Sarmentero (diegosarmentero) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== renamed file 'tests/platform/credentials/test_windows.py' => 'tests/platform/credentials/test_ipc_service.py'
2--- tests/platform/credentials/test_windows.py 2012-05-14 19:04:43 +0000
3+++ tests/platform/credentials/test_ipc_service.py 2012-06-14 22:35:22 +0000
4@@ -38,7 +38,7 @@
5 from contrib.testing.testcase import FAKED_CREDENTIALS
6 from ubuntuone.devtools.handlers import MementoHandler
7 from ubuntuone.platform.credentials import APP_NAME
8-from ubuntuone.platform.credentials.windows import (
9+from ubuntuone.platform.credentials.ipc_service import (
10 CredentialsManagement,
11 RemovableSignal,
12 logger,
13
14=== modified file 'tests/platform/credentials/test_linux.py'
15--- tests/platform/credentials/test_linux.py 2012-05-24 19:10:30 +0000
16+++ tests/platform/credentials/test_linux.py 2012-06-14 22:35:22 +0000
17@@ -46,7 +46,7 @@
18 logger,
19 UI_PARAMS,
20 )
21-from ubuntuone.platform.credentials.linux import (
22+from ubuntuone.platform.credentials.dbus_service import (
23 APP_NAME,
24 CredentialsManagement,
25 dbus,
26
27=== modified file 'ubuntuone/platform/credentials/__init__.py'
28--- ubuntuone/platform/credentials/__init__.py 2012-04-09 20:07:05 +0000
29+++ ubuntuone/platform/credentials/__init__.py 2012-06-14 22:35:22 +0000
30@@ -138,12 +138,12 @@
31
32 def get_platform_source(self):
33 """Platform-specific source."""
34- if sys.platform == 'win32':
35- from ubuntuone.platform.credentials import windows
36- source = windows
37+ if sys.platform in ('win32', 'darwin'):
38+ from ubuntuone.platform.credentials import ipc_service
39+ source = ipc_service
40 else:
41- from ubuntuone.platform.credentials import linux
42- source = linux
43+ from ubuntuone.platform.credentials import dbus_service
44+ source = dbus_service
45 return source
46
47 @defer.inlineCallbacks
48
49=== renamed file 'ubuntuone/platform/credentials/linux.py' => 'ubuntuone/platform/credentials/dbus_service.py'
50=== renamed file 'ubuntuone/platform/credentials/windows.py' => 'ubuntuone/platform/credentials/ipc_service.py'

Subscribers

People subscribed via source and target branches