Merge lp:~mikemc/ubuntuone-client/change-socket-name into lp:ubuntuone-client

Proposed by Mike McCracken on 2012-08-28
Status: Merged
Approved by: Manuel de la Peña on 2012-08-30
Approved revision: 1299
Merged at revision: 1305
Proposed branch: lp:~mikemc/ubuntuone-client/change-socket-name
Merge into: lp:ubuntuone-client
Diff against target: 12 lines (+1/-1)
1 file modified
ubuntuone/platform/filesystem_notifications/monitor/darwin/fsevents_daemon.py (+1/-1)
To merge this branch: bzr merge lp:~mikemc/ubuntuone-client/change-socket-name
Reviewer Review Type Date Requested Status
Manuel de la Peña (community) 2012-08-28 Approve on 2012-08-29
Review via email: mp+121643@code.launchpad.net

Commit Message

- Change socket name for daemon to match reverse DNS naming convention (LP: #1042785)

Description of the Change

- Change socket name for daemon to match reverse DNS naming convention (LP: #1042785)

To post a comment you must log in.
Manuel de la Peña (mandel) wrote :

Perfect.

review: Approve
Ubuntu One Auto Pilot (otto-pilot) wrote :
Download full text (259.1 KiB)

The attempt to merge lp:~mikemc/ubuntuone-client/change-socket-name into lp:ubuntuone-client failed. Below is the output from the failed tests.

/usr/bin/gnome-autogen.sh
checking for autoconf >= 2.53...
  testing autoconf2.50... not found.
  testing autoconf... found 2.69
checking for automake >= 1.10...
  testing automake-1.11... found 1.11.5
checking for libtool >= 1.5...
  testing libtoolize... found 2.4.2
checking for intltool >= 0.30...
  testing intltoolize... found 0.50.2
checking for pkg-config >= 0.14.0...
  testing pkg-config... found 0.26
checking for gtk-doc >= 1.0...
  testing gtkdocize... found 1.18
Checking for required M4 macros...
Checking for forbidden M4 macros...
Processing ./configure.ac
Running libtoolize...
libtoolize: putting auxiliary files in `.'.
libtoolize: copying file `./ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIR, `m4'.
libtoolize: copying file `m4/libtool.m4'
libtoolize: copying file `m4/ltoptions.m4'
libtoolize: copying file `m4/ltsugar.m4'
libtoolize: copying file `m4/ltversion.m4'
libtoolize: copying file `m4/lt~obsolete.m4'
Running intltoolize...
Running gtkdocize...
Running aclocal-1.11...
Running autoconf...
Running autoheader...
Running automake-1.11...
Running ./configure --enable-gtk-doc --enable-debug ...
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /bin/mkdir -p
checking for gawk... no
checking for mawk... mawk
checking whether make sets $(MAKE)... yes
checking how to create a ustar tar archive... gnutar
checking whether make supports nested variables... yes
checking for style of include used by make... GNU
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking dependency style of gcc... gcc3
checking for library containing strerror... none required
checking for gcc... (cached) gcc
checking whether we are using the GNU C compiler... (cached) yes
checking whether gcc accepts -g... (cached) yes
checking for gcc option to accept ISO C89... (cached) none needed
checking dependency style of gcc... (cached) gcc3
checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking how to print strings... printf
checking for a sed that does not truncate output... /bin/sed
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for fgrep... /bin/grep -F
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm -B
checking the name lister (/usr/bin/nm -B) interface... BSD nm
checking whether ln -s works... yes
checking the maximum length of command line arguments... 1572864
checking whether the shell understands some XSI constructs... y...

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ubuntuone/platform/filesystem_notifications/monitor/darwin/fsevents_daemon.py'
2--- ubuntuone/platform/filesystem_notifications/monitor/darwin/fsevents_daemon.py 2012-07-23 12:26:42 +0000
3+++ ubuntuone/platform/filesystem_notifications/monitor/darwin/fsevents_daemon.py 2012-08-28 15:20:27 +0000
4@@ -97,7 +97,7 @@
5
6 # TODO: This should be in fseventsd to be imported!
7 # Path to the socket used by the daemon
8-DAEMON_SOCKET = '/var/run/ubuntuone_fsevents_daemon'
9+DAEMON_SOCKET = '/var/run/com.ubuntu.one.fsevents.sock'
10
11
12 class DescriptionFactory(object):

Subscribers

People subscribed via source and target branches