Merge lp:~mikemc/ubuntu-system-settings-online-accounts/fix-remove-account-button into lp:ubuntu-system-settings-online-accounts

Proposed by Mike McCracken
Status: Merged
Approved by: Alberto Mardegan
Approved revision: 42
Merged at revision: 42
Proposed branch: lp:~mikemc/ubuntu-system-settings-online-accounts/fix-remove-account-button
Merge into: lp:ubuntu-system-settings-online-accounts
Diff against target: 12 lines (+1/-1)
1 file modified
src/module/Options.qml (+1/-1)
To merge this branch: bzr merge lp:~mikemc/ubuntu-system-settings-online-accounts/fix-remove-account-button
Reviewer Review Type Date Requested Status
Alberto Mardegan (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+183939@code.launchpad.net

Commit message

- Fix account removal button for OAuth accounts.

Description of the change

- Fix account removal button for OAuth accounts.

The account removal button was adding an extra undefined parameter to PopupUtils.open(), which isn't needed.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Alberto Mardegan (mardy) wrote :

Thanks, Mike, this fixes the problem indeed! No idea how this bug slipped in there in the first place :-)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/module/Options.qml'
2--- src/module/Options.qml 2013-07-11 10:06:49 +0000
3+++ src/module/Options.qml 2013-09-04 18:02:28 +0000
4@@ -47,7 +47,7 @@
5 control: Button {
6 text: i18n.dtr("ubuntu-system-settings-online-accounts", "Remove account…")
7 width: parent.width - units.gu(4)
8- onClicked: PopupUtils.open(removalConfirmationComponent, removeBtn)
9+ onClicked: PopupUtils.open(removalConfirmationComponent)
10 }
11 showDivider: false
12 }

Subscribers

People subscribed via source and target branches