lp:~mikemc/ubuntu-sso-client/fix-networkstate-darwin

Branch merges

Merged into lp:ubuntu-sso-client at revision 961

Diego Sarmentero (community): Approve on 2012-05-25

Manuel de la Peña (community): Approve on 2012-05-23

Diff: 630 lines (+514/-68)

4 files modified

ubuntu_sso/networkstate/darwin.py (+269/-61)
ubuntu_sso/networkstate/networkstates.py (+13/-7)
ubuntu_sso/networkstate/tests/run_nwmgr_standalone.py (+39/-0)
ubuntu_sso/networkstate/tests/test_darwin.py (+193/-0)

api

Propose for merging

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #984667: NetworkManager always returns we are connected on darwin

Undecided

Fix Released

Link a bug report

Related blueprints

975. By Mike McCracken on 2012-05-21

style fixes

974. By Mike McCracken on 2012-05-19

fixing yet another pep8 complaint missed by pep8 on darwin

973. By Mike McCracken on 2012-05-18

fix whitespace in blank lines that darwin lint didn't notice

972. By Mike McCracken on 2012-05-18

Fix lint and pep8 complaints, improve some names and docstrings

971. By Mike McCracken on 2012-05-17

fix dumb typo in tests that are only run on darwin

970. By Mike McCracken on 2012-05-16

merge with linux and windows test script branch so you can test this branch on linux and windows

969. By Mike McCracken on 2012-05-15

Marking as fixing bug 984667

968. By Mike McCracken on 2012-05-15

Implementation of network detection for darwin.

Uses similar approach to windows module - has a separate python thread
for listening for callbacks from the system API, which then calls back
to user code with one of the states defined in
networkstate/networkstates.py.

run-nwmgr-standalone.py is a utility for testing this API live, but in
isolation. It should be platform-independent. Just run it and it will
report on connection status for 60 seconds.

967. By Mike McCracken on 2012-05-10

make networkstate values into objects with readable labels for test failure output that makes sense

966. By Manuel de la Peña on 2012-05-03

Clean tests to work in all platforms.