Merge lp:~mikemc/ubuntu-sso-client/fix-1037395-run-mac-tests into lp:ubuntu-sso-client
Proposed by
Mike McCracken
on 2012-08-16
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | dobey on 2012-09-21 | ||||
| Approved revision: | 990 | ||||
| Merged at revision: | 1003 | ||||
| Proposed branch: | lp:~mikemc/ubuntu-sso-client/fix-1037395-run-mac-tests | ||||
| Merge into: | lp:ubuntu-sso-client | ||||
| Diff against target: |
20 lines (+2/-2) 1 file modified
run-mac-tests (+2/-2) |
||||
| To merge this branch: | bzr merge lp:~mikemc/ubuntu-sso-client/fix-1037395-run-mac-tests | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| dobey (community) | 2012-08-16 | Approve on 2012-09-21 | |
|
Review via email:
|
|||
Commit Message
- Change run-mac-tests script to work with fixed buildout, and use pyflakes (LP: #1037395)
Description of the Change
- Change run-mac-tests script to work with fixed buildout, and use pyflakes (LP: #1037395)
To post a comment you must log in.
review:
Approve
| dobey (dobey) wrote : | # |
review:
Needs Fixing
| Mike McCracken (mikemc) wrote : | # |
pylint is also broken on darwin…
I was thinking that if we're going to switch to pyflakes, we might as well start getting the warnings we're planning on fixing now, instead of getting errors we don't intend to fix.
review:
Approve

If using pyflakes here gives a bunch of warnings/errors, we probably do not want to switch to using it yet on darwin. You should probably not add the USE_PYFLAKES yet.