Merge lp:~mikemc/ubuntu-sso-client/fix-1012837-raise-and-shine into lp:ubuntu-sso-client

Proposed by Mike McCracken on 2012-06-13
Status: Merged
Approved by: Roberto Alsina on 2012-06-14
Approved revision: 970
Merged at revision: 969
Proposed branch: lp:~mikemc/ubuntu-sso-client/fix-1012837-raise-and-shine
Merge into: lp:ubuntu-sso-client
Diff against target: 23 lines (+3/-0)
2 files modified
ubuntu_sso/qt/main/__init__.py (+2/-0)
ubuntu_sso/qt/main/tests/test_main.py (+1/-0)
To merge this branch: bzr merge lp:~mikemc/ubuntu-sso-client/fix-1012837-raise-and-shine
Reviewer Review Type Date Requested Status
Roberto Alsina (community) 2012-06-13 Approve on 2012-06-14
Review via email: mp+110167@code.launchpad.net

Commit Message

- correctly bring main sso client window to the front on mac os x ( LP:1012837 )

Description of the Change

- correctly bring main sso client window to the front on mac os x ( LP:1012837 )

To post a comment you must log in.
969. By Mike McCracken on 2012-06-13

style change and add raise_ to mock ui object so tests pass.

970. By Mike McCracken on 2012-06-13

fix pep8 complaint

Mike McCracken (mikemc) wrote :

As of r970, tests pass on osx and linux and pylint and pep8 are happy.
mea culpa

Roberto Alsina (ralsina) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ubuntu_sso/qt/main/__init__.py'
2--- ubuntu_sso/qt/main/__init__.py 2012-05-09 18:00:22 +0000
3+++ ubuntu_sso/qt/main/__init__.py 2012-06-13 21:57:21 +0000
4@@ -80,5 +80,7 @@
5 ui.size(), app.desktop().availableGeometry())
6 ui.setGeometry(style)
7 ui.show()
8+ if sys.platform == 'darwin':
9+ ui.raise_()
10
11 source.main_start(app)
12
13=== modified file 'ubuntu_sso/qt/main/tests/test_main.py'
14--- ubuntu_sso/qt/main/tests/test_main.py 2012-05-09 17:48:32 +0000
15+++ ubuntu_sso/qt/main/tests/test_main.py 2012-06-13 21:57:21 +0000
16@@ -53,6 +53,7 @@
17 """Fake setGeometry."""
18
19 show = setGeometry
20+ raise_ = lambda self: None
21
22
23 class FakeDesktop(object):

Subscribers

People subscribed via source and target branches