Merge lp:~mikemc/ubuntu-download-manager/fix-1249470 into lp:ubuntu-download-manager

Proposed by Mike McCracken
Status: Merged
Approved by: Mike McCracken
Approved revision: 170
Merged at revision: 171
Proposed branch: lp:~mikemc/ubuntu-download-manager/fix-1249470
Merge into: lp:ubuntu-download-manager
Diff against target: 10 lines (+1/-1)
1 file modified
ubuntu-download-manager-tests/ubuntu-download-manager-tests.pro (+1/-1)
To merge this branch: bzr merge lp:~mikemc/ubuntu-download-manager/fix-1249470
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Alejandro J. Cura (community) Approve
Review via email: mp+194579@code.launchpad.net

Commit message

- change command for 'make check' to work when not in tree (LP: #1249470)

Description of the change

- change command for 'make check' to work when not in tree (LP: #1249470)

to test:
mkdir build
cd build
qmake ..
make -j check

without this change, this will fail with a symbol not found error.

To post a comment you must log in.
Revision history for this message
Alejandro J. Cura (alecu) wrote :

looks good

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ubuntu-download-manager-tests/ubuntu-download-manager-tests.pro'
2--- ubuntu-download-manager-tests/ubuntu-download-manager-tests.pro 2013-10-30 11:04:37 +0000
3+++ ubuntu-download-manager-tests/ubuntu-download-manager-tests.pro 2013-11-08 19:28:22 +0000
4@@ -77,6 +77,6 @@
5 DEPENDPATH += $$PWD/../libubuntudownloadmanager
6
7 check.depends = $${TARGET}
8-check.commands = LD_LIBRARY_PATH=$$PWD/../libubuntudownloadmanager ./$${TARGET}
9+check.commands = LD_LIBRARY_PATH=$$OUT_PWD/../libubuntudownloadmanager ./$${TARGET}
10 QMAKE_EXTRA_TARGETS += check
11

Subscribers

People subscribed via source and target branches