Merge lp:~mihirsoni/ubuntu-calendar-app/limitLablesModel into lp:ubuntu-calendar-app
Proposed by
Mihir Soni
Status: | Merged |
---|---|
Approved by: | Kunal Parmar |
Approved revision: | 522 |
Merged at revision: | 521 |
Proposed branch: | lp:~mihirsoni/ubuntu-calendar-app/limitLablesModel |
Merge into: | lp:ubuntu-calendar-app |
Diff against target: |
72 lines (+16/-12) 3 files modified
Defines.js (+1/-6) EventRepetition.qml (+5/-1) LimitLabelModel.qml (+10/-5) |
To merge this branch: | bzr merge lp:~mihirsoni/ubuntu-calendar-app/limitLablesModel |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Kunal Parmar | Approve | ||
Ubuntu Phone Apps Jenkins Bot | continuous-integration | Approve | |
Arto Jalkanen (community) | Approve | ||
Review via email: mp+239194@code.launchpad.net |
Commit message
Moved limitLabels from object to ListModel
Description of the change
Moved limitLabels from object to ListModel
To post a comment you must log in.
Looks good, so I'm just going to nitpick: the function() definition is intended too deep.