Merge lp:~mihirsoni/ubuntu-calendar-app/DesignFixDefaultWeekView-5 into lp:ubuntu-calendar-app

Proposed by Mihir Soni
Status: Rejected
Rejected by: Mihir Soni
Proposed branch: lp:~mihirsoni/ubuntu-calendar-app/DesignFixDefaultWeekView-5
Merge into: lp:ubuntu-calendar-app
Diff against target: 16 lines (+2/-2)
1 file modified
calendar.qml (+2/-2)
To merge this branch: bzr merge lp:~mihirsoni/ubuntu-calendar-app/DesignFixDefaultWeekView-5
Reviewer Review Type Date Requested Status
Kunal Parmar Abstain
Ubuntu Phone Apps Jenkins Bot continuous-integration Needs Fixing
Review via email: mp+240867@code.launchpad.net

Commit message

By default launch application in weekview instead of Month view.

Description of the change

By default launch application in weekview instead of Month view.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Kunal Parmar (pkunal-parmar) wrote :

as per latest design feedback
https://docs.google.com/presentation/d/14NIPecPFKb_8Ad3O4suEGJqVOw9bC4n0s63uWalbZ98/edit?usp=sharing_eid

MonthView is default view, so we dont need this

review: Abstain

Unmerged revisions

536. By Mihir Soni

Default view to weekview

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'calendar.qml'
--- calendar.qml 2014-10-22 13:23:19 +0000
+++ calendar.qml 2014-11-06 15:39:33 +0000
@@ -286,11 +286,11 @@
286 else {286 else {
287 // Due to bug #1231558 {if (args.defaultArgument.at(0))} is always true287 // Due to bug #1231558 {if (args.defaultArgument.at(0))} is always true
288 // After the fix we can delete this else288 // After the fix we can delete this else
289 tabs.selectedTabIndex= 1;289 tabs.selectedTabIndex= weekTab.index;
290 }290 }
291 } // End of if about args.values291 } // End of if about args.values
292 else {292 else {
293 tabs.selectedTabIndex= 1;293 tabs.selectedTabIndex= weekTab.index;
294 }294 }
295 } // End of Component.onCompleted:295 } // End of Component.onCompleted:
296296

Subscribers

People subscribed via source and target branches

to status/vote changes: