Merge lp:~mihirsoni/ubuntu-calendar-app/DesignFix-1 into lp:ubuntu-calendar-app

Proposed by Mihir Soni
Status: Merged
Approved by: Kunal Parmar
Approved revision: 529
Merged at revision: 528
Proposed branch: lp:~mihirsoni/ubuntu-calendar-app/DesignFix-1
Merge into: lp:ubuntu-calendar-app
Diff against target: 45 lines (+15/-2)
2 files modified
AllDayEventComponent.qml (+9/-2)
YearView.qml (+6/-0)
To merge this branch: bzr merge lp:~mihirsoni/ubuntu-calendar-app/DesignFix-1
Reviewer Review Type Date Requested Status
Kunal Parmar Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+239560@code.launchpad.net

Commit message

This fix resolve following changes :

1. All day event width same as other events.
2. Header Label in year view to current year.

Description of the change

This fix resolve following changes :

1. All day event width same as other events.
2. Header Label in year view to current year.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Kunal Parmar (pkunal-parmar) wrote :

This needs to be done only for DayView

review: Needs Fixing
529. By Mihir Soni

Fixed weekview , added Year string in YearView

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Kunal Parmar (pkunal-parmar) wrote :

looks good

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'AllDayEventComponent.qml'
2--- AllDayEventComponent.qml 2014-10-20 15:20:21 +0000
3+++ AllDayEventComponent.qml 2014-10-24 14:30:41 +0000
4@@ -33,6 +33,13 @@
5
6 width: parent.width
7
8+ anchors {
9+ left :parent.left
10+ right: parent.right
11+ leftMargin: type == ViewType.ViewTypeDay ? units.gu(6) : 0
12+ rightMargin: type == ViewType.ViewTypeDay ? units.gu(3): 0
13+ }
14+
15 function getAllDayEvents(startDate, endDate) {
16 var map = {};
17 var items = model.getItems(startDate,endDate);
18@@ -111,8 +118,8 @@
19 text = i18n.tr("%1 ev.").arg(events.length)
20 } else {
21 if( events.length > 1) {
22- // TRANSLATORS: the argument refers to the number of all day events
23- text = i18n.tr("%1 all day event", "%1 all day events", events.length).arg(events.length)
24+ // TRANSLATORS: the argument refers to the number of all day events
25+ text = i18n.tr("%1 all day event", "%1 all day events", events.length).arg(events.length)
26 } else {
27 text = events[0].displayLabel;
28 }
29
30=== modified file 'YearView.qml'
31--- YearView.qml 2014-10-22 18:39:27 +0000
32+++ YearView.qml 2014-10-24 14:30:41 +0000
33@@ -46,6 +46,12 @@
34 commonHeaderActions.showCalendarAction,
35 commonHeaderActions.reloadAction
36 ]
37+ contents: Label {
38+ id:year
39+ objectName:"yearLabel"
40+ fontSize: "x-large"
41+ text: i18n.tr("Year %1").arg(currentYear)
42+ }
43 }
44
45 PathViewBase {

Subscribers

People subscribed via source and target branches

to status/vote changes: