Merge lp:~mihirsoni/ubuntu-calendar-app/1335512 into lp:ubuntu-calendar-app

Proposed by Mihir Soni
Status: Superseded
Proposed branch: lp:~mihirsoni/ubuntu-calendar-app/1335512
Merge into: lp:ubuntu-calendar-app
Diff against target: 20 lines (+10/-0)
1 file modified
DayView.qml (+10/-0)
To merge this branch: bzr merge lp:~mihirsoni/ubuntu-calendar-app/1335512
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Needs Fixing
Ubuntu Calendar Developers Pending
Review via email: mp+225155@code.launchpad.net

This proposal has been superseded by a proposal from 2014-07-02.

Commit message

Resolved bug #1335512

Description of the change

Resolved bug #1335512

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

This fails due to https://bugs.launchpad.net/ubuntu-calendar-app/+bug/1335241, which affects trunk. Once a fix is released to trunk, I will rebuild this.

Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

I'd also like to see a test added for this :-)

Revision history for this message
Mihir Soni (mihirsoni) wrote :

This MR got merged automatically, without any reviews.

Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

Mihir, this is not in trunk.

Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'DayView.qml'
2--- DayView.qml 2014-05-31 04:38:48 +0000
3+++ DayView.qml 2014-07-01 13:15:28 +0000
4@@ -38,6 +38,16 @@
5 startX: -(dayHeader.width/7); startY: dayHeader.height/2
6 PathLine { x: (dayHeader.width/7) * 8 ; relativeY: 0; }
7 }
8+ onDateSelected: {
9+ if(date < currentDay){
10+ currentDay = currentDay.addDays(-1);
11+ dayHeader.decrementCurrentIndex()
12+ }
13+ else if( date > currentDay){
14+ currentDay = currentDay.addDays(1);
15+ dayHeader.incrementCurrentIndex();
16+ }
17+ }
18 }
19
20 PathViewBase{

Subscribers

People subscribed via source and target branches

to status/vote changes: