Merge lp:~mihirsoni/ubuntu-calculator-app/RemoveEqualSign-1203267 into lp:~ubuntu-calculator-dev/ubuntu-calculator-app/old_trunk

Proposed by Mihir Soni
Status: Merged
Approved by: Gustavo Pichorim Boiko
Approved revision: 122
Merged at revision: 122
Proposed branch: lp:~mihirsoni/ubuntu-calculator-app/RemoveEqualSign-1203267
Merge into: lp:~ubuntu-calculator-dev/ubuntu-calculator-app/old_trunk
Diff against target: 11 lines (+1/-1)
1 file modified
Simple/Screen.qml (+1/-1)
To merge this branch: bzr merge lp:~mihirsoni/ubuntu-calculator-app/RemoveEqualSign-1203267
Reviewer Review Type Date Requested Status
Gustavo Pichorim Boiko (community) Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Mihir Soni Pending
Review via email: mp+178673@code.launchpad.net

Commit message

Removed (=) equal sign from the result

Description of the change

Removed (=) equal sign from result

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

Looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Simple/Screen.qml'
2--- Simple/Screen.qml 2013-08-02 02:51:30 +0000
3+++ Simple/Screen.qml 2013-08-06 07:46:27 +0000
4@@ -235,7 +235,7 @@
5 id: formulaLabel
6 labelText: _text
7 numbers: _number
8- operation: _operation
9+ operation: _operation == "=" ? "" : _operation
10 numbersHeight: units.gu(5)
11 isLast: (isLastItem && index === repeater.model.count-1)
12

Subscribers

People subscribed via source and target branches