Merge lp:~miguelaraujo/mysql-proxy/loaded-plugins-logging into lp:mysql-proxy/0.8
Proposed by
Miguel Araújo
Status: | Merged |
---|---|
Approved by: | Jan Kneschke |
Approved revision: | 1230 |
Merge reported by: | Jan Kneschke |
Merged at revision: | not available |
Proposed branch: | lp:~miguelaraujo/mysql-proxy/loaded-plugins-logging |
Merge into: | lp:mysql-proxy/0.8 |
Diff against target: |
73 lines (+24/-5) 4 files modified
plugins/cli/cli-plugin.c (+2/-2) src/chassis-frontend.c (+14/-0) src/chassis-frontend.h (+5/-0) src/mysql-proxy-cli.c (+3/-3) |
To merge this branch: | bzr merge lp:~miguelaraujo/mysql-proxy/loaded-plugins-logging |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jan Kneschke (community) | Approve | ||
Review via email: mp+89737@code.launchpad.net |
This proposal supersedes a proposal from 2012-01-03.
Description of the change
Updated plugins chassis name value;
Added logging for the loaded plugins.
To post a comment you must log in.
1) don't prefix all plugin names by "MySQL" when logging. It is up to the plugin to define its full name it wants to announce
2) remove the CHASSIS_NEWLINE from the g_critical() to get rid of the double newline. g_critical() (as all g_log() functions) always adds a newline itself.