Midori Web Browser

Merge lp:~midori/midori/unownedMidoriCompletion into lp:midori

  1. unownedMidoriCompletion
  2. Merge into trunk
Proposed by Cris Dywan
Status: Merged
Approved by: Paweł Forysiuk
Approved revision: 6964
Merged at revision: 6968
Proposed branch: lp:~midori/midori/unownedMidoriCompletion
Merge into: lp:midori
Diff against target: 48 lines (+5/-5)
1 file modified
midori/midori-completion.vala (+5/-5)
To merge this branch: bzr merge lp:~midori/midori/unownedMidoriCompletion
Reviewer Review Type Date Requested Status
Paweł Forysiuk Approve
Review via email: mp+261794@code.launchpad.net

Commit message

Use unowned in foreach loops in Midori.Completion

To post a comment you must log in.
Revision history for this message
Paweł Forysiuk (tuxator) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'midori/midori-completion.vala'
2--- midori/midori-completion.vala 2015-04-04 19:20:47 +0000
3+++ midori/midori-completion.vala 2015-06-11 22:57:47 +0000
4@@ -75,7 +75,7 @@
5 }
6
7 public bool can_complete (string text) {
8- foreach (var completion in completions)
9+ foreach (unowned Completion completion in completions)
10 if (completion.can_complete (text))
11 return true;
12 return false;
13@@ -124,7 +124,7 @@
14 count++;
15 }
16
17- foreach (var suggestion in suggestions) {
18+ foreach (unowned Suggestion suggestion in suggestions) {
19 if (suggestion.uri == null) {
20 warning ("suggestion.uri != null");
21 continue;
22@@ -166,7 +166,7 @@
23 cancellable = new Cancellable ();
24 need_to_clear = true;
25
26- foreach (var completion in completions) {
27+ foreach (unowned Completion completion in completions) {
28 if (completion.can_complete (text))
29 yield complete_wrapped (completion, text, null, cancellable);
30 }
31@@ -175,7 +175,7 @@
32 public bool can_action (string action) {
33 if (action == "about:completion-description")
34 return true;
35- foreach (var completion in completions)
36+ foreach (unowned Completion completion in completions)
37 if (completion.can_action (action))
38 return true;
39 return false;
40@@ -190,7 +190,7 @@
41 cancellable = new Cancellable ();
42 need_to_clear = true;
43
44- foreach (var completion in completions) {
45+ foreach (unowned Completion completion in completions) {
46 if (completion.can_action (action))
47 complete_wrapped.begin (completion, text, action, cancellable);
48 }

Subscribers

People subscribed via source and target branches

to all changes: