Merge lp:~midori/midori/trailingCommas into lp:midori

Proposed by Cris Dywan
Status: Merged
Approved by: Paweł Forysiuk
Approved revision: 6559
Merged at revision: 6560
Proposed branch: lp:~midori/midori/trailingCommas
Merge into: lp:midori
Diff against target: 30 lines (+3/-3)
1 file modified
extensions/adblock/extension.vala (+3/-3)
To merge this branch: bzr merge lp:~midori/midori/trailingCommas
Reviewer Review Type Date Requested Status
Paweł Forysiuk Approve
Review via email: mp+207712@code.launchpad.net

Commit message

Don't use trailing comma on last list element in Adblock tests

To post a comment you must log in.
Revision history for this message
Paweł Forysiuk (tuxator) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'extensions/adblock/extension.vala'
2--- extensions/adblock/extension.vala 2014-02-20 18:27:01 +0000
3+++ extensions/adblock/extension.vala 2014-02-21 17:24:14 +0000
4@@ -422,7 +422,7 @@
5 { ".*foo/bar", "..*foo/bar" },
6 { "http://bla.blub/*", "http://bla.blub/.*" },
7 { "bag?r[]=*cpa", "bag\\?r\\[\\]=.*cpa" },
8- { "(facebookLike,", "(facebookLike," },
9+ { "(facebookLike,", "(facebookLike," }
10 };
11
12 void test_adblock_fixup_regexp () {
13@@ -457,7 +457,7 @@
14 { "https://bugs.webkit.org/buglist.cgi?query_format=advanced&short_desc_type=allwordssubstr&short_desc=&long_desc_type=substring&long_desc=&bug_file_loc_type=allwordssubstr&bug_file_loc=&keywords_type=allwords&keywords=&bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&emailassigned_to1=1&emailtype1=substring&email1=&emailassigned_to2=1&emailreporter2=1&emailcc2=1&emailtype2=substring&email2=&bugidtype=include&bug_id=&votes=&chfieldfrom=&chfieldto=Now&chfieldvalue=&query_based_on=gtkport&field0-0-0=keywords&type0-0-0=anywordssubstr&value0-0-0=Gtk%20Cairo%20soup&field0-0-1=short_desc&type0-0-1=anywordssubstr&value0-0-1=Gtk%20Cairo%20soup%20autoconf%20automake%20autotool&field0-0-2=component&type0-0-2=equals&value0-0-2=WebKit%20Gtk", Adblock.Directive.ALLOW },
15 { "http://www.engadget.com/2009/09/24/google-hits-android-rom-modder-with-a-cease-and-desist-letter/", Adblock.Directive.ALLOW },
16 { "http://karibik-invest.com/es/bienes_raices/search.php?sqT=19&sqN=&sqMp=&sqL=0&qR=1&sqMb=&searchMode=1&action=B%FAsqueda", Adblock.Directive.ALLOW },
17- { "http://google.com", Adblock.Directive.ALLOW },
18+ { "http://google.com", Adblock.Directive.ALLOW }
19 };
20
21 string pretty_directive (Adblock.Directive? directive) {
22@@ -503,7 +503,7 @@
23 { "[Adblock]\n! dutchblock v3\n! This list expires after 14 days\n|http://b*.mookie1.com/\n", false },
24 { "[Adblock Plus 2.0]\n! Last modification time (GMT): 2012.11.05 13:33\n! Expires: 5 days (update frequency)\n", true },
25 { "[Adblock Plus 2.0]\n! Last modification time (GMT): 2012.11.05 13:33\n", true },
26- { "[Adblock]\n ! dummy, i dont have any dates\n", false },
27+ { "[Adblock]\n ! dummy, i dont have any dates\n", false }
28 };
29
30 void test_subscription_update () {

Subscribers

People subscribed via source and target branches

to all changes: