Merge lp:~midori/midori/snapcraft into lp:midori
Proposed by
Cris Dywan
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Cody Garver | ||||
Approved revision: | 7171 | ||||
Merged at revision: | 7166 | ||||
Proposed branch: | lp:~midori/midori/snapcraft | ||||
Merge into: | lp:midori | ||||
Diff against target: |
185 lines (+121/-21) 4 files modified
config/CMakeLists.txt (+1/-1) midori/midori-app.c (+5/-17) midori/midori-view.c (+6/-3) snap/snapcraft.yaml (+109/-0) |
||||
To merge this branch: | bzr merge lp:~midori/midori/snapcraft | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Cody Garver (community) | Approve | ||
axlrose112 | Pending | ||
Review via email: mp+330129@code.launchpad.net |
Commit message
Snap packaging
Description of the change
Adds a snapcraft.yaml to build a Midori snap, built with WebKit2 and GTK+3.
This also includes a CMake build fix, a missing icon info NULL-check and uses a simpler hash for the GApplication.name exposed over DBus so that it works with confinement.
To post a comment you must log in.
I got Segmentation fault and after ran it with gb I got:
Program received signal SIGSEGV, Segmentation fault. view_apply_ icon (view=0x856444200, icon=0x856451790, icon_name=0x0) Hacking/ LaunchPad/ snapcraft/ midori/ midori- view.c: 449
0x00000008008c18de in midori_
at /home/jamesaxl/
449 g_warning ("Could not load pixbuf for icon '%s': %s\n", icon_name, error->message);