Midori Web Browser

Merge lp:~midori/midori/printfMessage into lp:midori

  1. printfMessage
  2. Merge into trunk
Proposed by Cris Dywan
Status: Merged
Approved by: gue5t gue5t
Approved revision: 6589
Merged at revision: 6589
Proposed branch: lp:~midori/midori/printfMessage
Merge into: lp:midori
Diff against target: 13 lines (+2/-1)
1 file modified
extensions/open-with.vala (+2/-1)
To merge this branch: bzr merge lp:~midori/midori/printfMessage
Reviewer Review Type Date Requested Status
gue5t gue5t Approve
Review via email: mp+209799@code.launchpad.net

Commit message

printf URI in show_message_dialog for download error

To post a comment you must log in.
Revision history for this message
gue5t gue5t (gue5t) wrote :

Thanks for catching this!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'extensions/open-with.vala'
2--- extensions/open-with.vala 2014-03-06 20:47:05 +0000
3+++ extensions/open-with.vala 2014-03-06 22:07:22 +0000
4@@ -666,7 +666,8 @@
5 else if (download.status == WebKit.DownloadStatus.ERROR)
6 Midori.show_message_dialog (Gtk.MessageType.ERROR,
7 _("Download error"),
8- _("Cannot open '%s' because the download failed.") + download.destination_uri, false);
9+ _("Cannot open '%s' because the download failed."
10+ ).printf (download.destination_uri), false);
11 });
12 download.start ();
13 return true;

Subscribers

People subscribed via source and target branches

to all changes: