Merge lp:~midori/midori/lostHamburger into lp:midori

Proposed by Cris Dywan
Status: Merged
Approved by: Paweł Forysiuk
Approved revision: 6970
Merged at revision: 6986
Proposed branch: lp:~midori/midori/lostHamburger
Merge into: lp:midori
Diff against target: 30 lines (+9/-4)
1 file modified
midori/midori-window.vala (+9/-4)
To merge this branch: bzr merge lp:~midori/midori/lostHamburger
Reviewer Review Type Date Requested Status
Paweł Forysiuk Approve
Review via email: mp+261899@code.launchpad.net

Commit message

Always include app menu in toolbar

To post a comment you must log in.
Revision history for this message
Paweł Forysiuk (tuxator) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'midori/midori-window.vala'
2--- midori/midori-window.vala 2015-06-12 22:04:05 +0000
3+++ midori/midori-window.vala 2015-06-13 14:33:18 +0000
4@@ -125,7 +125,14 @@
5 foreach (unowned Gtk.Widget toolitem in container.get_children ())
6 container.remove (toolitem);
7
8- string[] names = actions.replace ("CompactMenu", extra_actions + ",CompactMenu").split (",");
9+ /* Always include app menu (visible depending on menubar) and extensions. */
10+ string all_actions;
11+ if ("CompactMenu" in actions)
12+ all_actions = actions.replace ("CompactMenu", extra_actions + ",CompactMenu");
13+ else
14+ all_actions = actions + "," + extra_actions + ",CompactMenu";
15+ string[] names = all_actions.split (",");
16+
17 #if HAVE_GTK3
18 var headerbar = _toolbar as Gtk.HeaderBar;
19 if (headerbar != null) {
20@@ -147,9 +154,7 @@
21 } else if (name == "Search") {
22 ((Gtk.Entry)widget).width_chars = 12;
23 tail.append (toolitem);
24- } else if (actions.index_of (name) > actions.index_of ("Location"))
25- tail.append (toolitem);
26- else if (name in extra_actions)
27+ } else if (all_actions.index_of (name) > all_actions.index_of ("Location"))
28 tail.append (toolitem);
29 else
30 headerbar.pack_start (toolitem);

Subscribers

People subscribed via source and target branches

to all changes: