Merge lp:~midori/midori/goBackOnThemedIcons into lp:midori

Proposed by Cris Dywan
Status: Merged
Approved by: Paweł Forysiuk
Approved revision: 6643
Merged at revision: 6644
Proposed branch: lp:~midori/midori/goBackOnThemedIcons
Merge into: lp:midori
Diff against target: 65 lines (+15/-20)
3 files modified
extensions/adblock/widgets.vala (+1/-1)
icons/CMakeLists.txt (+12/-9)
katze/midori-paths.vala (+2/-10)
To merge this branch: bzr merge lp:~midori/midori/goBackOnThemedIcons
Reviewer Review Type Date Requested Status
Paweł Forysiuk Approve
Review via email: mp+213952@code.launchpad.net

Commit message

Revert install Adblock icons as proper icons and move to own icon folder

To post a comment you must log in.
Revision history for this message
Paweł Forysiuk (tuxator) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== renamed file 'icons/scalable/adblock-blocked.svg' => 'data/adblock/blocked.svg'
2=== renamed file 'icons/scalable/adblock-disabled.svg' => 'data/adblock/disabled.svg'
3=== renamed file 'icons/scalable/adblock-enabled.svg' => 'data/adblock/enabled.svg'
4=== modified file 'extensions/adblock/widgets.vala'
5--- extensions/adblock/widgets.vala 2014-03-19 22:38:23 +0000
6+++ extensions/adblock/widgets.vala 2014-04-03 17:07:41 +0000
7@@ -41,7 +41,7 @@
8 }
9
10 public void set_status (string status) {
11- icon.set_from_icon_name ("adblock-%s".printf (status), Gtk.IconSize.MENU);
12+ icon.set_from_file (Midori.Paths.get_res_filename ("adblock/%s.png".printf (status)));
13 }
14 }
15
16
17=== modified file 'icons/CMakeLists.txt'
18--- icons/CMakeLists.txt 2014-03-19 23:03:25 +0000
19+++ icons/CMakeLists.txt 2014-04-03 17:07:41 +0000
20@@ -1,10 +1,13 @@
21-# Copyright (C) 2013-2014 Christian Dywan <christian@twotoasts.de>
22-
23-file(GLOB SIZES RELATIVE ${CMAKE_CURRENT_SOURCE_DIR} */)
24-list(REMOVE_ITEM SIZES "CMakeLists.txt")
25-foreach(SIZE ${SIZES})
26- file(GLOB ICONS RELATIVE ${CMAKE_CURRENT_SOURCE_DIR}/ ${SIZE}/*)
27- foreach(ICON ${ICONS})
28- install(FILES ${ICON} DESTINATION ${CMAKE_INSTALL_DATADIR}/${CMAKE_PROJECT_NAME}/icons/${SIZE})
29- endforeach()
30+# Copyright (C) 2013 Christian Dywan <christian@twotoasts.de>
31+
32+macro(install_icon name cat size)
33+ file(GLOB FILENAME RELATIVE ${CMAKE_CURRENT_SOURCE_DIR} "${size}/${name}.*")
34+ install(FILES ${FILENAME} DESTINATION ${CMAKE_INSTALL_DATADIR}/icons/hicolor/${size}/${cat})
35+endmacro()
36+
37+foreach(SIZE 16x16 22x22 scalable)
38+ install_icon(midori apps ${SIZE})
39+ install_icon(extension categories ${SIZE})
40+ install_icon(internet-news-reader status ${SIZE})
41 endforeach()
42+
43
44=== modified file 'katze/midori-paths.vala'
45--- katze/midori-paths.vala 2014-03-26 21:12:05 +0000
46+++ katze/midori-paths.vala 2014-04-03 17:07:41 +0000
47@@ -183,17 +183,9 @@
48 #endif
49 }
50
51- string fallback_icons1 = Path.build_filename (MDATADIR, PACKAGE_NAME, "icons", "scalable");
52- Gtk.IconTheme.get_default ().append_search_path (fallback_icons1);
53-#if !HAVE_WIN32
54- string? fallback_icons2 = build_folder ("icons", null, "scalable");
55- if (fallback_icons2 != null)
56- Gtk.IconTheme.get_default ().append_search_path (fallback_icons2);
57-#endif
58-
59 if (strcmp (Environment.get_variable ("MIDORI_DEBUG"), "paths") == 0) {
60- stdout.printf ("config: %s\ncache: %s\nuser_data: %s\ntmp: %s\nicons: %s\n",
61- config_dir, cache_dir, user_data_dir, tmp_dir, fallback_icons1);
62+ stdout.printf ("config: %s\ncache: %s\nuser_data: %s\ntmp: %s\n",
63+ config_dir, cache_dir, user_data_dir, tmp_dir);
64 }
65 }
66

Subscribers

People subscribed via source and target branches

to all changes: