Merge lp:~midori/midori/fix-build-after-granite into lp:midori

Proposed by Paweł Forysiuk
Status: Merged
Approved by: Cris Dywan
Approved revision: 6636
Merged at revision: 6636
Proposed branch: lp:~midori/midori/fix-build-after-granite
Merge into: lp:midori
Diff against target: 16 lines (+3/-2)
1 file modified
midori/midori-notebook.vala (+3/-2)
To merge this branch: bzr merge lp:~midori/midori/fix-build-after-granite
Reviewer Review Type Date Requested Status
Rico Tzschichholz (community) Needs Fixing
Cris Dywan Approve
frenchy82 (community) testing Approve
Review via email: mp+213374@code.launchpad.net

Commit message

Properly guard usage of gtk3 get_style_context

To post a comment you must log in.
Revision history for this message
frenchy82 (cartes) wrote :

build is ok on gtk2 (ubuntu 12.04)

review: Approve (testing)
Revision history for this message
Cris Dywan (kalikiana) wrote :

That's wrong, this is GTK+3 not Granite.

review: Needs Fixing
6636. By Paweł Forysiuk

Dynamic notebook class is not specific to granite

Revision history for this message
Cris Dywan (kalikiana) wrote :

Looks good, thanks!

review: Approve
Revision history for this message
Rico Tzschichholz (ricotz) wrote :

It should require both

#if HAVE_GTK3 && HAVE_GRANITE
...
#end

review: Needs Fixing

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'midori/midori-notebook.vala'
2--- midori/midori-notebook.vala 2014-03-29 21:45:57 +0000
3+++ midori/midori-notebook.vala 2014-03-30 14:01:28 +0000
4@@ -207,9 +207,10 @@
5 notebook.show_border = false;
6 notebook.set ("group-name", PACKAGE_NAME);
7 add (notebook);
8+
9+#if HAVE_GTK3
10 get_style_context ().add_class ("dynamic-notebook");
11-
12-#if !HAVE_GTK3
13+#else
14 /* Remove the inner border between scrollbars and window border */
15 Gtk.RcStyle rcstyle = new Gtk.RcStyle ();
16 rcstyle.xthickness = 0;

Subscribers

People subscribed via source and target branches

to all changes: