Merge lp:~midori/midori/fix-1094858 into lp:midori

Proposed by Danielle Foré
Status: Merged
Merged at revision: 6168
Proposed branch: lp:~midori/midori/fix-1094858
Merge into: lp:midori
Diff against target: 32 lines (+0/-4)
1 file modified
midori/midori-locationaction.c (+0/-4)
To merge this branch: bzr merge lp:~midori/midori/fix-1094858
Reviewer Review Type Date Requested Status
Cris Dywan Approve
Review via email: mp+164681@code.launchpad.net

Description of the change

No idea what this does, just migrating a patch to a bzr branch. From the original report:

"midori/midori-locationaction.c: Remove unused pointer `background`

    The pointer `background` is not used in `midori_location_entry_render_text_cb()`."

To post a comment you must log in.
lp:~midori/midori/fix-1094858 updated
6163. By Paul Menzel

remove unused pointer background

Revision history for this message
Cris Dywan (kalikiana) wrote :

Makes sense, in fact there's 2 more instances of this pattern: declaring 'background' when it's actually already handled by the bound attributes. I'm taking care of those bits.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'midori/midori-locationaction.c'
2--- midori/midori-locationaction.c 2013-04-18 23:16:56 +0000
3+++ midori/midori-locationaction.c 2013-05-20 08:54:25 +0000
4@@ -352,12 +352,10 @@
5 {
6 MidoriLocationAction* action = data;
7 gchar* title;
8- gchar* background;
9 gchar* desc;
10
11 gtk_tree_model_get (model, iter,
12 MIDORI_AUTOCOMPLETER_COLUMNS_MARKUP, &title,
13- MIDORI_AUTOCOMPLETER_COLUMNS_BACKGROUND, &background,
14 -1);
15
16 if (strchr (title, '\n')) /* A search engine or action suggestion */
17@@ -365,7 +363,6 @@
18 gchar** parts = g_strsplit (title, "\n", 2);
19 desc = g_strdup (parts[0]);
20 g_strfreev (parts);
21- g_free (background);
22 }
23 else
24 {
25@@ -406,7 +403,6 @@
26 gchar** parts = g_strsplit (title, "\n", 2);
27 desc = g_strdup (parts[1]);
28 g_strfreev (parts);
29- g_free (background);
30 }
31 else
32 {

Subscribers

People subscribed via source and target branches

to all changes: