Merge lp:~midori/midori/domainkeysfixes into lp:midori

Proposed by Paweł Forysiuk
Status: Merged
Approved by: Cris Dywan
Approved revision: 6582
Merged at revision: 6582
Proposed branch: lp:~midori/midori/domainkeysfixes
Merge into: lp:midori
Diff against target: 21 lines (+2/-2)
1 file modified
extensions/domain-keys.vala (+2/-2)
To merge this branch: bzr merge lp:~midori/midori/domainkeysfixes
Reviewer Review Type Date Requested Status
Cris Dywan Approve
Review via email: mp+209141@code.launchpad.net

Commit message

Fix building ctrl+enter extension with older versions of vala

To post a comment you must log in.
Revision history for this message
Cris Dywan (kalikiana) wrote :

Looks good, and seems to work as before. Tested with different Vala versions.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'extensions/domain-keys.vala'
2--- extensions/domain-keys.vala 2014-03-02 18:25:40 +0000
3+++ extensions/domain-keys.vala 2014-03-03 22:53:12 +0000
4@@ -13,7 +13,7 @@
5 class Manager : Midori.Extension {
6 internal Manager () {
7 GLib.Object (name: _("Domain Hotkeys"),
8- description: _("Add www. and .com/.country_domain and proceed with Ctrl+Enter/Ctrl+Shift"),
9+ description: _("Add www. and .com/.country_domain and proceed with Ctrl+Enter/Shift+Enter"),
10 version: "0.1" + Midori.VERSION_SUFFIX,
11 authors: "James Axl <bilimish@yandex.ru>");
12 activate.connect (this.activated);
13@@ -21,7 +21,7 @@
14 }
15
16 bool key_press_event (Midori.LocationAction action, Gdk.EventKey event_key) {
17- if (event_key.keyval == Gdk.Key.Return) {
18+ if (event_key.keyval == Gdk.keyval_from_name ("Return")) {
19 if ((bool)(event_key.state & Gdk.ModifierType.CONTROL_MASK)) {
20 submit_uri(action);
21 return true;

Subscribers

People subscribed via source and target branches

to all changes: