Merge lp:~midori/midori/adblockHicolor into lp:midori

Proposed by Cris Dywan
Status: Merged
Approved by: Danielle Foré
Approved revision: 7005
Merged at revision: 7016
Proposed branch: lp:~midori/midori/adblockHicolor
Merge into: lp:midori
Diff against target: 34 lines (+5/-3)
2 files modified
extensions/adblock/widgets.vala (+1/-2)
icons/CMakeLists.txt (+4/-1)
To merge this branch: bzr merge lp:~midori/midori/adblockHicolor
Reviewer Review Type Date Requested Status
gue5t gue5t Approve
Review via email: mp+267458@code.launchpad.net

Commit message

Move adblock icons to hicolor

To post a comment you must log in.
Revision history for this message
Danielle Foré (danrabbit) wrote :

Works here. Don't forget to sudo gtk-update-icon-cache /usr/share/icons/hicolor/

Revision history for this message
Cris Dywan (kalikiana) wrote :

Indeed that was it. Works perfectly now!

Please review if it also works for you.

Revision history for this message
gue5t gue5t (gue5t) wrote :

Tested with "export GDK_SCALE=2 midori", and it uses double-resolution rasterizations in that case (and behaves right without hidpi as well).

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'extensions/adblock/widgets.vala'
2--- extensions/adblock/widgets.vala 2015-06-11 22:47:42 +0000
3+++ extensions/adblock/widgets.vala 2015-08-09 20:48:55 +0000
4@@ -54,8 +54,7 @@
5 }
6
7 void set_status (string status) {
8- gicon = new GLib.FileIcon (File.new_for_path (
9- Midori.Paths.get_res_filename ("adblock/%s.png".printf (status))));
10+ gicon = new GLib.ThemedIcon ("adblock-%s".printf (status));
11 }
12
13 public void set_state (Adblock.State state) {
14
15=== added directory 'icons/24x24'
16=== renamed file 'data/adblock/blocked.svg' => 'icons/24x24/adblock-blocked.svg'
17=== renamed file 'data/adblock/disabled.svg' => 'icons/24x24/adblock-disabled.svg'
18=== renamed file 'data/adblock/enabled.svg' => 'icons/24x24/adblock-enabled.svg'
19=== modified file 'icons/CMakeLists.txt'
20--- icons/CMakeLists.txt 2014-04-03 00:49:01 +0000
21+++ icons/CMakeLists.txt 2015-08-09 20:48:55 +0000
22@@ -5,9 +5,12 @@
23 install(FILES ${FILENAME} DESTINATION ${CMAKE_INSTALL_DATADIR}/icons/hicolor/${size}/${cat})
24 endmacro()
25
26-foreach(SIZE 16x16 22x22 scalable)
27+foreach(SIZE 16x16 22x22 24x24 scalable)
28 install_icon(midori apps ${SIZE})
29 install_icon(extension categories ${SIZE})
30 install_icon(internet-news-reader status ${SIZE})
31+ install_icon(adblock-enabled status ${SIZE})
32+ install_icon(adblock-blocked status ${SIZE})
33+ install_icon(adblock-disabled status ${SIZE})
34 endforeach()
35

Subscribers

People subscribed via source and target branches

to all changes: