Merge lp:~midokura/nova/network-service into lp:~ntt-pf-lab/nova/network-service

Proposed by Ryu Ishimoto
Status: Merged
Merge reported by: Ryu Ishimoto
Merged at revision: not available
Proposed branch: lp:~midokura/nova/network-service
Merge into: lp:~ntt-pf-lab/nova/network-service
Diff against target: 58 lines (+12/-6)
2 files modified
nova/db/sqlalchemy/migrate_repo/versions/015_diablo.py (+0/-1)
nova/network/service.py (+12/-5)
To merge this branch: bzr merge lp:~midokura/nova/network-service
Reviewer Review Type Date Requested Status
NTT PF Lab. Pending
Review via email: mp+58614@code.launchpad.net

Commit message

Removed a bad 'return' statement in the migration file.

Description of the change

Removed a bad 'return' statement in the migration file.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'nova/db/sqlalchemy/migrate_repo/versions/015_diablo.py'
--- nova/db/sqlalchemy/migrate_repo/versions/015_diablo.py 2011-04-12 10:57:56 +0000
+++ nova/db/sqlalchemy/migrate_repo/versions/015_diablo.py 2011-04-21 05:21:12 +0000
@@ -68,7 +68,6 @@
68 # Upgrade operations go here. Don't create your own engine;68 # Upgrade operations go here. Don't create your own engine;
69 # bind migrate_engine to your metadata69 # bind migrate_engine to your metadata
70 meta.bind = migrate_engine70 meta.bind = migrate_engine
71 return
7271
73 for table in (instance_virtual_nic_association, 72 for table in (instance_virtual_nic_association,
74 project_network_service_association):73 project_network_service_association):
7574
=== modified file 'nova/network/service.py'
--- nova/network/service.py 2011-04-17 20:45:38 +0000
+++ nova/network/service.py 2011-04-21 05:21:12 +0000
@@ -468,6 +468,14 @@
468 self._mapper = mapper468 self._mapper = mapper
469 self._service = service469 self._service = service
470470
471 def _get_prefix(self):
472 """ Get the route prefix from the service name.
473
474 Returns:
475 The route prefix.
476 """
477 return "/%s" % str(self._service.__package__).replace(".", "/")
478
471 def resource(self, member_name, collection_name, **kwargs):479 def resource(self, member_name, collection_name, **kwargs):
472 """Wrapper method for 'resource' method in python-routes mapper object.480 """Wrapper method for 'resource' method in python-routes mapper object.
473481
@@ -478,23 +486,22 @@
478 member_name: REST member routes486 member_name: REST member routes
479 collection_name: REST collection routes487 collection_name: REST collection routes
480 """488 """
481 _, _, package_name = str(self._service.__package__).rpartition('.')489 prefix = self._get_prefix()
482 kwargs.pop('path_prefix', None)490 kwargs.pop('path_prefix', None)
483 self._mapper.resource(member_name, collection_name,491 self._mapper.resource(member_name, collection_name,
484 path_prefix='/%s' % package_name, **kwargs)492 path_prefix=prefix, **kwargs)
485493
486 def connect(self, *args, **kwargs):494 def connect(self, *args, **kwargs):
487 """Wrapper for 'connect' method.495 """Wrapper for 'connect' method.
488 """496 """
489 _, _, package_name = str(self._service.__package__).rpartition('.')
490
491 if len(args) < 1:497 if len(args) < 1:
492 new_args = args498 new_args = args
493 else:499 else:
494 end = ()500 end = ()
495 if len(args) > 2:501 if len(args) > 2:
496 end = args[2:]502 end = args[2:]
497 new_path = "/%s%s" % (package_name, args[1])503 prefix = self._get_prefix()
504 new_path = "%s%s" % (prefix, args[1])
498 new_args = args[0:1] + (new_path, ) + end505 new_args = args[0:1] + (new_path, ) + end
499506
500 self._mapper.connect(*new_args, **kwargs)507 self._mapper.connect(*new_args, **kwargs)

Subscribers

People subscribed via source and target branches

to status/vote changes: