lp:~michihenning/unity-scopes-api/location-data

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:unity-scopes-api/devel at revision 535

Marcus Tomlinson (community): Approve on 2014-11-21

PS Jenkins bot (community): Approve (continuous-integration) on 2014-11-20

Michał Sawicz: Needs Fixing on 2014-11-20

Diff: 138 lines (+36/-15)

6 files modified

include/unity/scopes/internal/SettingsSchema.h (+3/-0)
scoperegistry/scoperegistry.cpp (+3/-1)
src/scopes/internal/IniSettingsSchema.cpp (+8/-0)
src/scopes/internal/JsonSettingsSchema.cpp (+13/-5)
test/gtest/scopes/internal/JsonSettingsSchema/JsonSettingsSchema_test.cpp (+3/-3)
test/gtest/scopes/internal/smartscopes/smartscopesproxy/smartscopesproxy_test.cpp (+6/-6)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1393438: "Enable location data" string displays untranslated

High

Invalid

Link a bug report

Related blueprints

537. By Michi Henning on 2014-11-20

Re-instated original internal.location setting.

536. By Michi Henning on 2014-11-20

Forcing commit because Jenkins won't give me rebuild button after a builder died.

535. By Michi Henning on 2014-11-20

Removed previous internal.location setting.

534. By Michi Henning on 2014-11-20

Fixes for bug #1393438: "Enable location data" string displays untranslated.
Added internal.location.precision settings metadata with possible values
None, Approximate, and Precise. This allows the shell to treat this setting
as "special" and to supply the correct localized strings for the display name
and the possible display values for the setting. I left the original
internal.location setting in place, to allow for a smooth transition from
the old hack (boolean), to the new hack (enum). Eventually, we need to
back out the hacks altogether because, ideally, the shell should only
pay attention to the LocationDataNeeded metadata attribute.

While fixing this, I found another bug: for setting schemas parsed from
an .ini file, the enumerator choices were in a dictionary entry called
"displayValues" but, when parsing from an equivalent JSON string, the
dictionary entry was called "values". "displayNames" is correct, so that's
what the code now does, regardless of whether the schema is written in
JSON or as a .ini file. The only affected part of the code is the
smartscopes proxy, which is the only part of the system that gets JSON
settings definitions.

533. By Paweł Stołowski on 2014-11-19

Pass lat/lon to smart scopes server (if enabled in scope settings and available). Fixes: https://bugs.launchpad.net/bugs/1386709.

Approved by PS Jenkins bot, Facundo Batista, Michi Henning.

532. By Michi Henning on 2014-11-19

Added app_directory() method to ScopeBase. It returns the directory that is shared if an app and a scope are installed from a single click packages. The directory is writable to the app, but only readable to the scope, so the app can pass information to the scope, but not vice versa.

Updated doc accordingly and added new section to the tutorial for this.

Renamed DataDir config item in Runtime.ini to CacheDir, for consistency with the public API naming.

Added tests and tightened a few existing tests.

Added missing directory set methods to TypedScopeFixture. Fixes: https://bugs.launchpad.net/bugs/1384286.

Approved by Pawel Stolowski, PS Jenkins bot.

531. By Marcus Tomlinson on 2014-11-18

Improved information provided by some exceptions. Client-side invocation logic now reports the operation name when a TimeoutException is thrown. . Fixes: https://bugs.launchpad.net/bugs/1351477.

Approved by Michi Henning, PS Jenkins bot.

530. By Michi Henning on 2014-11-18

Changed registry to use different exception when adding a watch for file exists, file does not exist, and all other errors. The previous approach of using ResourceException for everything conflated expected errors with surprising errors, so we never found out when inotify_add_watch() return ENOSPC, which seems to be happening on Vivid, as well as (sporadically) for Arm on Jenkins.

Also reduced linger time for twoway invocations to 100 ms (from 500 ms). Previous linger was too long and could cause spurious messages about the zmq context being slow to shut down.

Approved by Pawel Stolowski, PS Jenkins bot.

529. By Michi Henning on 2014-11-13

Added version attribute to metadata received from remote scopes.

Approved by PS Jenkins bot, Marcus Tomlinson.

528. By Michi Henning on 2014-11-10

Added Version attribute to Scope.ini and scope metadata.

Approved by Pawel Stolowski, PS Jenkins bot.