lp:~michihenning/unity-scopes-api/app-armor-noise

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:unity-scopes-api/devel at revision 511

Paweł Stołowski (community): Approve on 2014-10-13

PS Jenkins bot (community): Approve (continuous-integration) on 2014-10-10

Diff: 236 lines (+81/-47)

6 files modified

CONFIGFILES (+2/-1)
debian/libunity-scopes3.symbols (+5/-1)
include/unity/scopes/internal/DfltConfig.h.in (+0/-1)
include/unity/scopes/internal/RuntimeImpl.h (+5/-1)
scoperegistry/scoperegistry.cpp (+11/-2)
src/scopes/internal/RuntimeImpl.cpp (+58/-41)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1376416: apparmor denial to cache for confined scopes	High	Fix Released
Bug #1378805: denial for creating /run/user/32011/scopes/leaf-net/	Critical	Fix Released

Link a bug report

Related blueprints

507. By Michi Henning on 2014-10-10

Fixed symbols file.

506. By Michi Henning on 2014-10-10

Fixes for bugs #1378805 and 1376416.
Guarded attempts to create directories that must exist but
cannot be created by confined scopes so only unconfined scopes
will try to create the directories. This allows us to directly
run a scope stand-alone via the scoperunner.
For confined scopes, the registry creates the parent directories
before exec'ing a scope.
This should avoid the noise in app_armor logs about attempts
by confined scopes to create directories they aren't allowed to
created.
Fixed incorrect location of cache directory in RuntimeImpl:
/home/phablet/.local/share/unity-scopes/com.ubuntu.yelp_help
was wrong. It now is:
/home/phablet/.local/share/unity-scopes/leaf-net/com.ubuntu.yelp.
This should shut up the app_armor noise too.
Removed DFLT_CONFINEMENT_TYPE from DfltConfig.h.in because
it was unused.

505. By Marcus Tomlinson on 2014-10-09

1. Removed SIGNON_SESSION_DATA_UI_POLICY specification (use default always) as this is actually a bug in OA not scopes (Bug #1374394).

2. Removed pub-sub network for authentication as this is no longer needed when using the default UI policy.

3. Updated test.

Approved by Pawel Stolowski, PS Jenkins bot.

504. By Michi Henning on 2014-10-09

More permanent fix for the Zmq infinite reconnection problem.
The outgoing connection pool now runs a reaper that removes
sockets from the pool after ten seconds idle time. Fixes: https://bugs.launchpad.net/bugs/1364464, https://bugs.launchpad.net/bugs/1374206.

Approved by Marcus Tomlinson, PS Jenkins bot.

503. By Michi Henning on 2014-10-09

Fixed a few compiler warnings in OnlineAccountClient_test.

Approved by Marcus Tomlinson, PS Jenkins bot.

502. By Marcus Tomlinson on 2014-10-08

Added tests for OnlineAccountClient.

Approved by PS Jenkins bot, Pawel Stolowski.

501. By Marcus Tomlinson on 2014-10-08

1. Depending on whether OnlineAccountClient is used by the shell or by a scope, set the SIGNON_SESSION_DATA_UI_POLICY accordingly.

2. Inform scopes of successful user authentications via a pub/sub network.

3. Removed inc_logins() and dec_logins() as only one session can be active per service (now using info->session != nullptr).

4. Added better thread and exception safety.

5. Run the internal event loop within its own context to avoid clashing with external main loops. Fixes: https://bugs.launchpad.net/bugs/1374394, https://bugs.launchpad.net/bugs/1377147.

Approved by PS Jenkins bot, Pawel Stolowski.

500. By Michi Henning on 2014-10-08

Updated HACKING with interim instructions for dealing with architecture-specific symbols, until we get around to fixing the symbol diff script (which, unfortunately, is not entirely trivial).

See bug #1378182.

Approved by Pawel Stolowski, PS Jenkins bot.

499. By Paweł Stołowski on 2014-10-07

Merged trunk

498. By Michi Henning on 2014-10-07

Fixed desktop file generation: if the Icon attribute wasn't present, the registry printed a bunch of error message for the demo scopes (which don't set the icon), claiming that all demo scope were ignored, when, in fact, they weren't ignored. Instead, their desktop files were only partially written.

Approved by PS Jenkins bot, Marcus Tomlinson.