unity-scopes-api

Merge lp:~michihenning/unity-scopes-api/add-logging into lp:unity-scopes-api

  1. add-logging
  2. Merge into trunk
Proposed by Michi Henning
Status: Merged
Approved by: Paweł Stołowski
Approved revision: 574
Merged at revision: 305
Proposed branch: lp:~michihenning/unity-scopes-api/add-logging
Merge into: lp:unity-scopes-api
Diff against target: 24 lines (+2/-2)
2 files modified
CONFIGFILES (+1/-1)
include/unity/scopes/internal/DfltConfig.h.in (+1/-1)
To merge this branch: bzr merge lp:~michihenning/unity-scopes-api/add-logging
Reviewer Review Type Date Requested Status
Paweł Stołowski (community) Approve
Review via email: mp+248478@code.launchpad.net

Commit message

Reduced log history to 2 MB per scope.

Description of the change

Reduced log history to 2 MB per scope. I don't see a point in wasting more space than this.

To post a comment you must log in.
Revision history for this message
Paweł Stołowski (stolowski) wrote :

Right. +1

review: Approve
Revision history for this message
Paweł Stołowski (stolowski) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CONFIGFILES'
2--- CONFIGFILES 2015-01-26 08:22:10 +0000
3+++ CONFIGFILES 2015-02-04 07:10:18 +0000
4@@ -154,7 +154,7 @@
5
6 The maximum size in bytes of the sum of sizes of all log files in the log directory
7 before they are deleted. The value must be greater than Log.MaxFileSize.
8- The default value is 10 MB.
9+ The default value is 2 MB.
10
11 - Log.TraceChannels
12
13
14=== modified file 'include/unity/scopes/internal/DfltConfig.h.in'
15--- include/unity/scopes/internal/DfltConfig.h.in 2015-01-16 02:59:43 +0000
16+++ include/unity/scopes/internal/DfltConfig.h.in 2015-02-04 07:10:18 +0000
17@@ -59,7 +59,7 @@
18 static constexpr char const* DFLT_HOME_LOG_SUBDIR = ".local/share/unity-scopes";
19
20 static constexpr int DFLT_MAX_LOG_FILE_SIZE = 512 * 1024; // bytes, individual file size
21-static constexpr int DFLT_MAX_LOG_DIR_SIZE = 10 * 1024 * 1024; // bytes, sum of file sizes
22+static constexpr int DFLT_MAX_LOG_DIR_SIZE = 2 * 1024 * 1024; // bytes, sum of file sizes
23
24 } // namespace internal
25

Subscribers

People subscribed via source and target branches

to all changes: