Merge lp:~michihenning/unity-api/fix-readme-install into lp:unity-api

Proposed by Michi Henning
Status: Merged
Approved by: Michał Sawicz
Approved revision: 35
Merged at revision: 35
Proposed branch: lp:~michihenning/unity-api/fix-readme-install
Merge into: lp:unity-api
Diff against target: 82 lines (+10/-22)
2 files modified
INSTALL (+7/-18)
README (+3/-4)
To merge this branch: bzr merge lp:~michihenning/unity-api/fix-readme-install
Reviewer Review Type Date Requested Status
Michał Sawicz Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+163634@code.launchpad.net

Commit message

Minor fixed to README and INSTALL files.

Description of the change

Minor fixed to README and INSTALL files.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Michał Sawicz (saviq) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'INSTALL'
2--- INSTALL 2013-03-15 11:14:42 +0000
3+++ INSTALL 2013-05-14 04:54:27 +0000
4@@ -24,18 +24,7 @@
5 Build dependencies
6 ------------------
7
8-List of packages required to build and test the code:
9-
10-- cmake (cmake, 2.8.10 with patch (see below) or later)
11-- gcovr (gcovr, 2.4-0ubuntu1 or later)
12-- lcov (lcov, 1.9-3 with patch (see below) or later)
13-- gtest (libgtest-dev, 1.6.0 or later)
14-- cppcheck (cppcheck, 1.55-1 or later)
15-- doxygen (doxygen, 1.8.1.2-1 or later)
16-- graphviz (graphviz, 2.26.3-12ubuntu1 or later)
17-- libboost (libboost1.49-dev or later)
18-- libboost-thread (libbost-thread1.49-dev or later)
19-- libboost-regex-dev (libbost-regex1.49-dev or later)
20+See debian/control for the list of packages required to build and test the code.
21
22
23 Building the code
24@@ -59,7 +48,7 @@
25 To build with the flags for coverage testing enabled:
26
27 $ mkdir buildcoverage
28- $ cd makecoverage
29+ $ cd buildcoverage
30 $ cmake -DCMAKE_BUILD_TYPE=coverage
31 $ make
32
33@@ -85,8 +74,8 @@
34 $ make test
35 $ make coverage-html
36
37-(The coverage-html target is available only if the code was built with -DCMAKE_BUILD_TYPE=coverage.)
38-
39+This drops the coverage tests into the coveragereport directory. (The coverage-html target is available
40+only if the code was built with -DCMAKE_BUILD_TYPE=coverage.)
41
42 Note that, with gcc 4.7.2 and cmake 2.8.10, you may get a bunch of
43 warnings. To fix this, you can build cmake 2.8.10 with the following patch:
44@@ -114,10 +103,10 @@
45
46 This deletes all the .gcda files, allowing the merge to succeed again.
47
48-If lcov complains about unrecognized lines, apply this patch
49-to /usr/bin/geninfo:
50+If lcov complains about unrecognized lines involving '=====',
51+you can patch geninfo and gcovr as explained here:
52
53-https://bugzilla.redhat.com/attachment.cgi?id=590034
54+https://bugs.launchpad.net/gcovr/+bug/1086695/comments/2
55
56 To run the static C++ checks:
57
58
59=== modified file 'README'
60--- README 2013-03-28 06:10:55 +0000
61+++ README 2013-05-14 04:54:27 +0000
62@@ -59,9 +59,7 @@
63 Header file conventions
64 -----------------------
65
66-TODO: Is include/unity/scopes the correct place?
67-
68-All header files are underneath include/unity/scopes. Source code always includes
69+All header files are underneath include/unity. Source code always includes
70 headers using the full pathname, for example:
71
72 #include <unity/internal/ExceptionImpl.h>
73@@ -73,7 +71,8 @@
74 there are no duplicate names, inclusion with angle brackets behaves the
75 same way as inclusion with double quotes.)
76
77-All headers that are for public consumption appear in unity/scopes.
78+All headers that are for public consumption appear in include/unity/*
79+(provided the path does not include "internal").
80
81 Public header directories contain a private header directory called
82 "internal". This directory contains all the headers that are private

Subscribers

People subscribed via source and target branches

to all changes: