Unity API

Merge lp:~michihenning/unity-api/fix-cppcheck into lp:unity-api

  1. fix-cppcheck
  2. Merge into trunk
Proposed by Michi Henning
Status: Merged
Approved by: Jussi Pakkanen
Approved revision: 55
Merged at revision: 55
Proposed branch: lp:~michihenning/unity-api/fix-cppcheck
Merge into: lp:unity-api
Diff against target: 12 lines (+1/-1)
1 file modified
CMakeLists.txt (+1/-1)
To merge this branch: bzr merge lp:~michihenning/unity-api/fix-cppcheck
Reviewer Review Type Date Requested Status
Jussi Pakkanen (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+168567@code.launchpad.net

Commit message

Added --check-config to the cppcheck target, so we get better diagnostics.

Description of the change

Added --check-config to the cppcheck target, so we get better diagnostics.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:55
http://jenkins.qa.ubuntu.com/job/unity-api-ci/63/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-api-saucy-armhf-ci/20
        deb: http://jenkins.qa.ubuntu.com/job/unity-api-saucy-armhf-ci/20/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-api-saucy-i386-ci/21

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-api-ci/63/rebuild

review: Approve (continuous-integration)
Revision history for this message
Jussi Pakkanen (jpakkane) wrote :

Fine by me.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CMakeLists.txt'
2--- CMakeLists.txt 2013-06-06 23:34:50 +0000
3+++ CMakeLists.txt 2013-06-10 23:58:29 +0000
4@@ -46,7 +46,7 @@
5
6 # Static C++ checks
7
8-set(cppcheck_flags --inline-suppr --enable=all -q --error-exitcode=2)
9+set(cppcheck_flags --check-config --inline-suppr --enable=all -q --error-exitcode=2)
10 set(cppcheck_flags ${cppcheck_flags} --template '{file}({line}): {severity} ({id}): {message}')
11
12 add_custom_target(cppcheck COMMAND cppcheck ${cppcheck_flags}

Subscribers

People subscribed via source and target branches

to all changes: