Merge lp:~michihenning/unity-api/crash-fix into lp:unity-api
Status: | Merged |
---|---|
Approved by: | Jussi Pakkanen |
Approved revision: | 108 |
Merged at revision: | 106 |
Proposed branch: | lp:~michihenning/unity-api/crash-fix |
Merge into: | lp:unity-api |
Diff against target: |
11 lines (+0/-1) 1 file modified
CMakeLists.txt (+0/-1) |
To merge this branch: | bzr merge lp:~michihenning/unity-api/crash-fix |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot (community) | continuous-integration | Approve | |
Unity Team | Pending | ||
Review via email: mp+187641@code.launchpad.net |
Commit message
Reverting commit 89, which added -D_GLIBCXX_DEBUG.
This has truly hideous consequences when calling cross-library and passing STL types.
If not all libraries involved are compiled with the same flag, the code links and runs and,
in many cases, will work, except in some cases, where suddenly the stack gets trashed, the
code segfaults on a memory allocation, or similar.
Description of the change
Reverting commit 89, which added -D_GLIBCXX_DEBUG.
This has truly hideous consequences when calling cross-library and passing STL types.
If not all libraries involved are compiled with the same flag, the code links and runs and,
in many cases, will work, except in some cases, where suddenly the stack gets trashed, the
code segfaults on a memory allocation, or similar.
PASSED: Continuous integration, rev:108 jenkins. qa.ubuntu. com/job/ unity-api- ci/123/ jenkins. qa.ubuntu. com/job/ unity-api- saucy-amd64- ci/5 jenkins. qa.ubuntu. com/job/ unity-api- saucy-armhf- ci/80 jenkins. qa.ubuntu. com/job/ unity-api- saucy-armhf- ci/80/artifact/ work/output/ *zip*/output. zip jenkins. qa.ubuntu. com/job/ unity-api- saucy-i386- ci/81
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins: 8080/job/ unity-api- ci/123/ rebuild
http://