Merge lp:~michihenning/unity-api/crash-fix into lp:unity-api

Proposed by Michi Henning
Status: Merged
Approved by: Jussi Pakkanen
Approved revision: 108
Merged at revision: 106
Proposed branch: lp:~michihenning/unity-api/crash-fix
Merge into: lp:unity-api
Diff against target: 11 lines (+0/-1)
1 file modified
CMakeLists.txt (+0/-1)
To merge this branch: bzr merge lp:~michihenning/unity-api/crash-fix
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Unity Team Pending
Review via email: mp+187641@code.launchpad.net

Commit message

Reverting commit 89, which added -D_GLIBCXX_DEBUG.
This has truly hideous consequences when calling cross-library and passing STL types.
If not all libraries involved are compiled with the same flag, the code links and runs and,
in many cases, will work, except in some cases, where suddenly the stack gets trashed, the
code segfaults on a memory allocation, or similar.

Description of the change

Reverting commit 89, which added -D_GLIBCXX_DEBUG.
This has truly hideous consequences when calling cross-library and passing STL types.
If not all libraries involved are compiled with the same flag, the code links and runs and,
in many cases, will work, except in some cases, where suddenly the stack gets trashed, the
code segfaults on a memory allocation, or similar.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CMakeLists.txt'
2--- CMakeLists.txt 2013-09-02 07:12:56 +0000
3+++ CMakeLists.txt 2013-09-26 02:56:20 +0000
4@@ -99,7 +99,6 @@
5 set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fvisibility=hidden")
6
7 set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11 -fno-permissive -pedantic -Wall -Wextra")
8-set(CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} -D_GLIBCXX_DEBUG")
9
10 if ("${CMAKE_BUILD_TYPE}" STREQUAL "release" OR "${CMAKE_BUILD_TYPE}" STREQUAL "relwithdebinfo")
11 option(Werror "Treat warnings as errors" ON)

Subscribers

People subscribed via source and target branches

to all changes: