Merge lp:~michihenning/thumbnailer/merge-crossbuild into lp:thumbnailer
Proposed by
Michi Henning
Status: | Merged |
---|---|
Approved by: | James Henstridge |
Approved revision: | 153 |
Merged at revision: | 149 |
Proposed branch: | lp:~michihenning/thumbnailer/merge-crossbuild |
Merge into: | lp:thumbnailer |
Diff against target: |
105 lines (+26/-11) 5 files modified
debian/changelog (+13/-0) debian/control (+1/-1) debian/copyright (+2/-0) include/internal/trace.h (+5/-5) src/trace.cpp (+5/-5) |
To merge this branch: | bzr merge lp:~michihenning/thumbnailer/merge-crossbuild |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
James Henstridge | Approve | ||
Review via email: mp+300691@code.launchpad.net |
Commit message
Changed python-tornado dependency to python-tornado <!nocheck> for cross-builds.
Description of the change
Changed python-tornado dependency to python-tornado <!nocheck> for cross-builds.
To post a comment you must log in.
I'm not convinced this is correct: while it might get rid of the dependency mess when running under crossbuild, it isn't clear that it is the right option if we were actually to attempt to run the tests.
Better would be to use build profiles to remove the dependency entirely in this configuration:
https:/ /wiki.debian. org/BuildProfil eSpec
Ideally we could change it to something like:
python3-tornado <!nocheck>
But currently crossbuilder isn't setting that profile. It is setting the "cross" profile though, but we really want this tied to whether tests are being run rather than whether it is being cross compiled.