lp:~michihenning/thumbnailer/http-response-codes

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:thumbnailer/devel at revision 310

PS Jenkins bot (community): Approve (continuous-integration) on 2015-12-14

Michi Henning (community): Approve on 2015-12-14

James Henstridge: Approve on 2015-12-14

Diff: 2052 lines (+588/-572)

13 files modified

debian/changelog (+2/-0)
include/internal/artreply.h (+3/-4)
include/internal/thumbnailer.h (+3/-2)
include/internal/ubuntuserverdownloader.h (+0/-1)
src/service/handler.cpp (+10/-7)
src/thumbnailer.cpp (+184/-177)
src/ubuntuserverdownloader.cpp (+88/-88)
src/vs-thumb/thumbnailextractor.cpp (+3/-0)
tests/dbus/dbus_test.cpp (+18/-6)
tests/download/download_test.cpp (+57/-52)
tests/libthumbnailer-qt/libthumbnailer-qt_test.cpp (+47/-48)
tests/slow-vs-thumb/slow-vs-thumb_test.cpp (+1/-10)
tests/thumbnailer/thumbnailer_test.cpp (+172/-177)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1512608: No thumbnails generated for OGG audio

High

Fix Released

Link a bug report

Related blueprints

314. By Michi Henning on 2015-12-04

Merged devel and resolved conflicts.

313. By Michi Henning on 2015-12-04

Removed trace, updated changelog.

312. By Michi Henning on 2015-12-04

Some tidy-up, stricter tests.

311. By Michi Henning on 2015-12-04

More thorough server error test. Make sure we always get a duration in the log,
even if check() returns an error status.

310. By Michi Henning on 2015-12-04

Temporary check-in, moving machines.

309. By Michi Henning on 2015-12-03

Tighter tests, better diagnostics, unified error handling. fetch() is noexcept now
and download() no longer throws for unsurprising errors (permission denied,
server down, etc.) Still need to adjust logic in handler to not call
download if check() reports an error.

308. By Michi Henning on 2015-12-02

Removed redundant error check.

307. By Michi Henning on 2015-12-02

Refactored ArtReply and UbuntuServerArtReply.

306. By Michi Henning on 2015-12-02

Removed stale thumbnailer tests. Changed network retry test to use recoverable error code.

305. By Michi Henning on 2015-12-01

Added lsb-release to build deps.

Approved by James Henstridge, PS Jenkins bot.