Storage Framework

Merge lp:~michihenning/storage-framework/less-test-noise into lp:storage-framework/devel

  1. less-test-noise
  2. Merge into devel
Proposed by Michi Henning
Status: Merged
Approved by: James Henstridge
Approved revision: 82
Merged at revision: 85
Proposed branch: lp:~michihenning/storage-framework/less-test-noise
Merge into: lp:storage-framework/devel
Diff against target: 30 lines (+3/-3)
1 file modified
tests/utils/fake-online-accounts-daemon.py (+3/-3)
To merge this branch: bzr merge lp:~michihenning/storage-framework/less-test-noise
Reviewer Review Type Date Requested Status
James Henstridge Approve
unity-api-1-bot continuous-integration Approve
Review via email: mp+309716@code.launchpad.net

Commit message

Reduce noise from fake online accounts daemon.

Description of the change

Reduce noise from fake online accounts daemon.

To post a comment you must log in.
Revision history for this message
unity-api-1-bot (unity-api-1-bot) wrote :

PASSED: Continuous integration, rev:82
https://jenkins.canonical.com/unity-api-1/job/lp-storage-framework-ci/165/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build/931
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/938
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=vivid+overlay/741
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=vivid+overlay/741/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/741
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/741/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=yakkety/741
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=yakkety/741/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=vivid+overlay/741
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=vivid+overlay/741/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/741
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/741/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=yakkety/741
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=yakkety/741/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=vivid+overlay/741
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=vivid+overlay/741/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/741
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/741/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=yakkety/741
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=yakkety/741/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-storage-framework-ci/165/rebuild

review: Approve (continuous-integration)
Revision history for this message
James Henstridge (jamesh) wrote :

Looks god.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/utils/fake-online-accounts-daemon.py'
2--- tests/utils/fake-online-accounts-daemon.py 2016-09-28 11:58:35 +0000
3+++ tests/utils/fake-online-accounts-daemon.py 2016-11-01 03:38:17 +0000
4@@ -116,7 +116,7 @@
5 @dbus.service.method(dbus_interface=OA_IFACE,
6 in_signature="a{sv}", out_signature="a(ua{sv})")
7 def GetAccounts(self, filters):
8- print("GetAccounts %r" % filters)
9+ #print("GetAccounts %r" % filters)
10 sys.stdout.flush()
11 return dbus.Array([a.serialise() for a in self.accounts],
12 signature="a(ua{sv})")
13@@ -124,7 +124,7 @@
14 @dbus.service.method(dbus_interface=OA_IFACE,
15 in_signature="usbba{sv}", out_signature="a{sv}")
16 def Authenticate(self, account_id, service_id, interactive, invalidate, parameters):
17- print("Authenticate %r %r %r %r %r" % (account_id, service_id, interactive, invalidate, parameters))
18+ #print("Authenticate %r %r %r %r %r" % (account_id, service_id, interactive, invalidate, parameters))
19 sys.stdout.flush()
20 for account in self.accounts:
21 if account.account_id == account_id and account.service_id == service_id:
22@@ -135,7 +135,7 @@
23 @dbus.service.method(dbus_interface=OA_IFACE,
24 in_signature="sa{sv}", out_signature="(ua{sv})a{sv}")
25 def RequestAccess(self, service_id, parameters):
26- print("RequestAccess %r %r" % (service_id, parameters))
27+ #print("RequestAccess %r %r" % (service_id, parameters))
28 sys.stdout.flush()
29 for account in self.accounts:
30 if account.service_id == service_id:

Subscribers

People subscribed via source and target branches

to all changes: