Code review comment for lp:~michihenning/online-accounts-api/leak-fix

Revision history for this message
Michi Henning (michihenning) wrote :

Well, if this doesn't convince you, I don't know what will. This has cost us quite a few hours. And, by using QScopedPointer or unique_ptr, this bug could never have happened in the first place.

I cannot for the life of me see what writing the code with a raw pointer and an explicit delete is preferable when, with a smart pointer, no code is needed at all.

« Back to merge proposal