Merge ~michal-maloszewski99/ubuntu/+source/ruby-faraday:fix-deprec into ubuntu/+source/ruby-faraday:ubuntu/devel

Proposed by Michał Małoszewski
Status: Work in progress
Proposed branch: ~michal-maloszewski99/ubuntu/+source/ruby-faraday:fix-deprec
Merge into: ubuntu/+source/ruby-faraday:ubuntu/devel
Diff against target: 203 lines (+114/-2) (has conflicts)
6 files modified
debian/changelog (+8/-0)
debian/patches/fix-deprec-msg.patch (+82/-0)
debian/patches/series (+7/-0)
lib/faraday/adapter/em_http.rb (+1/-1)
lib/faraday/options.rb (+11/-0)
lib/faraday/response.rb (+5/-1)
Conflict in debian/changelog
Conflict in debian/patches/series
Conflict in lib/faraday/options.rb
Conflict in lib/faraday/response.rb
Reviewer Review Type Date Requested Status
git-ubuntu import Pending
Review via email: mp+426629@code.launchpad.net
To post a comment you must log in.

Unmerged commits

56fe3c3... by Michał Małoszewski

sdsdsds

e9fb789... by Michał Małoszewski

sds

5ac4bcc... by Michał Małoszewski

sdsds

9082b2b... by Michał Małoszewski

sdsds

4afe2e7... by Michał Małoszewski

dsdsd

abcc9c2... by Michał Małoszewski

sds

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 1f86e9d..8571346 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,4 @@
6+<<<<<<< debian/changelog
7 ruby-faraday (1.1.0-7) unstable; urgency=medium
8
9 [ Jenkins ]
10@@ -94,6 +95,13 @@ ruby-faraday (1.0.0-1) experimental; urgency=medium
11 * Add ruby-rspec as build dependency
12
13 -- Pirate Praveen <praveen@debian.org> Thu, 06 Feb 2020 17:11:57 +0100
14+=======
15+ruby-faraday (0.15.4-3ubuntu0.1) focal; urgency=medium
16+
17+ * Fix deprec messages
18+
19+ -- Michal Maloszewski <michal.maloszewski@canonical.com> Tue, 05 Jul 2022 20:47:02 +0200
20+>>>>>>> debian/changelog
21
22 ruby-faraday (0.15.4-3) unstable; urgency=medium
23
24diff --git a/debian/patches/fix-deprec-msg.patch b/debian/patches/fix-deprec-msg.patch
25new file mode 100644
26index 0000000..951dc08
27--- /dev/null
28+++ b/debian/patches/fix-deprec-msg.patch
29@@ -0,0 +1,82 @@
30+Description: <short summary of the patch>
31+ TODO: Put a short summary on the line above and replace this paragraph
32+ with a longer explanation of this change. Complete the meta-information
33+ with other relevant fields (see below for details). To make it easier, the
34+ information below has been extracted from the changelog. Adjust it or drop
35+ it..
36+ .
37+ ruby-faraday (0.15.4-3) unstable; urgency=medium
38+ .
39+ * Fix Breaks for ruby-oauth2 (1.4.1 is compatible)
40+Author: Pirate Praveen <praveen@debian.org>
41+
42+---
43+The information above should follow the Patch Tagging Guidelines, please
44+checkout http://dep.debian.net/deps/dep3/ to learn about the format. Here
45+are templates for supplementary fields that you might want to add:
46+
47+Origin: <vendor|upstream|other>, <url of original patch>
48+Bug: <url in upstream bugtracker>
49+Bug-Debian: https://bugs.debian.org/<bugnumber>
50+Bug-Ubuntu: https://launchpad.net/bugs/<bugnumber>
51+Forwarded: <no|not-needed|url proving that it has been forwarded>
52+Reviewed-By: <name and email of someone who approved the patch>
53+Last-Update: 2022-07-05
54+
55+Index: ruby1/lib/faraday/adapter/em_http.rb
56+===================================================================
57+--- ruby1.orig/lib/faraday/adapter/em_http.rb
58++++ ruby1/lib/faraday/adapter/em_http.rb
59+@@ -193,11 +193,11 @@ module Faraday
60+
61+ def running?() @running end
62+
63+- def add
64++ def add(&block)
65+ if running?
66+ perform_request { yield }
67+ else
68+- @registered_procs << Proc.new
69++ @registered_procs << block
70+ end
71+ @num_registered += 1
72+ end
73+Index: ruby1/lib/faraday/options.rb
74+===================================================================
75+--- ruby1.orig/lib/faraday/options.rb
76++++ ruby1/lib/faraday/options.rb
77+@@ -72,7 +72,7 @@ module Faraday
78+ if args.size > 0
79+ send(key_setter, args.first)
80+ elsif block_given?
81+- send(key_setter, Proc.new.call(key))
82++ send(key_setter, yield(key))
83+ else
84+ raise self.class.fetch_error_class, "key not found: #{key.inspect}"
85+ end
86+@@ -163,7 +163,8 @@ module Faraday
87+ end
88+
89+ def self.memoized(key)
90+- memoized_attributes[key.to_sym] = Proc.new
91++ memoized_attributes[key.to_sym] = &block
92++
93+ class_eval <<-RUBY, __FILE__, __LINE__ + 1
94+ def #{key}() self[:#{key}]; end
95+ RUBY
96+Index: ruby1/lib/faraday/response.rb
97+===================================================================
98+--- ruby1.orig/lib/faraday/response.rb
99++++ ruby1/lib/faraday/response.rb
100+@@ -54,9 +54,9 @@ module Faraday
101+ !!env
102+ end
103+
104+- def on_complete
105++ def on_complete(&block)
106+ if not finished?
107+- @on_complete_callbacks << Proc.new
108++ @on_complete_callbacks << block
109+ else
110+ yield(env)
111+ end
112diff --git a/debian/patches/series b/debian/patches/series
113index 823d159..164c03c 100644
114--- a/debian/patches/series
115+++ b/debian/patches/series
116@@ -1,5 +1,12 @@
117 skip-test-failure-on-warning.patch
118 001_remove-bundler.patch
119+<<<<<<< debian/patches/series
120 require-faraday.patch
121 remove-coveralls.patch
122 skip-test-failing-in-ubuntu.patch
123+=======
124+003_gemspec-no-git.patch
125+disable-tests-localhost-port4.patch
126+use-system-lib.patch
127+fix-deprec-msg.patch
128+>>>>>>> debian/patches/series
129diff --git a/lib/faraday/adapter/em_http.rb b/lib/faraday/adapter/em_http.rb
130index f2d98c5..fcc5cb0 100644
131--- a/lib/faraday/adapter/em_http.rb
132+++ b/lib/faraday/adapter/em_http.rb
133@@ -18,7 +18,7 @@ module Faraday
134 configure_ssl(options, env)
135 options
136 end
137-
138+#
139 def request_config(env)
140 options = {
141 body: read_body(env),
142diff --git a/lib/faraday/options.rb b/lib/faraday/options.rb
143index ee198d8..b2eaa68 100644
144--- a/lib/faraday/options.rb
145+++ b/lib/faraday/options.rb
146@@ -29,8 +29,13 @@ module Faraday
147 else
148 new_value = value
149 end
150+<<<<<<< lib/faraday/options.rb
151
152 send("#{key}=", new_value) unless new_value.nil?
153+=======
154+#
155+ self.send("#{key}=", new_value) unless new_value.nil?
156+>>>>>>> lib/faraday/options.rb
157 end
158 self
159 end
160@@ -167,12 +172,18 @@ module Faraday
161 @attribute_options ||= {}
162 end
163
164+<<<<<<< lib/faraday/options.rb
165 def self.memoized(key, &block)
166 unless block_given?
167 raise ArgumentError, '#memoized must be called with a block'
168 end
169
170 memoized_attributes[key.to_sym] = block
171+=======
172+ def self.memoized(key)
173+ memoized_attributes[key.to_sym] = &block
174+
175+>>>>>>> lib/faraday/options.rb
176 class_eval <<-RUBY, __FILE__, __LINE__ + 1
177 def #{key}() self[:#{key}]; end
178 RUBY
179diff --git a/lib/faraday/response.rb b/lib/faraday/response.rb
180index e931ea0..f25dace 100644
181--- a/lib/faraday/response.rb
182+++ b/lib/faraday/response.rb
183@@ -1,7 +1,7 @@
184 # frozen_string_literal: true
185
186 require 'forwardable'
187-
188+#
189 module Faraday
190 # Response represents an HTTP response from making an HTTP request.
191 class Response
192@@ -59,7 +59,11 @@ module Faraday
193 end
194
195 def on_complete(&block)
196+<<<<<<< lib/faraday/response.rb
197 if !finished?
198+=======
199+ if not finished?
200+>>>>>>> lib/faraday/response.rb
201 @on_complete_callbacks << block
202 else
203 yield(env)

Subscribers

People subscribed via source and target branches