Merge ~michal-maloszewski99/ubuntu/+source/openssh:fix-outdated-ssh into ubuntu/+source/openssh:ubuntu/focal

Proposed by Michał Małoszewski
Status: Superseded
Proposed branch: ~michal-maloszewski99/ubuntu/+source/openssh:fix-outdated-ssh
Merge into: ubuntu/+source/openssh:ubuntu/focal
Diff against target: 84 lines (+62/-0)
3 files modified
debian/changelog (+7/-0)
debian/patches/fix-outdated-info-ssh-conf.patch (+54/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
Andreas Hasenack Needs Fixing
Canonical Server Reporter Pending
git-ubuntu import Pending
Review via email: mp+427460@code.launchpad.net

This proposal has been superseded by a proposal from 2022-07-27.

To post a comment you must log in.
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Grabbing this, some changes requested.

review: Needs Fixing

Unmerged commits

5793845... by Michał Małoszewski

changelog

388c3ee... by Michał Małoszewski

Fix ssh_config(5) which contains outdated information (LP: #1871465)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index e9ee5d1..bb7123d 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,10 @@
6+openssh (1:8.2p1-4ubuntu0.1) UNRELEASED; urgency=medium
7+
8+ * d/p/fix-outdated-info-ssh-conf.patch: Fix outdated information
9+ (LP: #1871465)
10+
11+ -- Michal Maloszewski <michal.maloszewski@canonical.com> Tue, 26 Jul 2022 21:51:55 +0200
12+
13 openssh (1:8.2p1-4) unstable; urgency=medium
14
15 * Add /etc/ssh/ssh_config.d/ to openssh-client.
16diff --git a/debian/patches/fix-outdated-info-ssh-conf.patch b/debian/patches/fix-outdated-info-ssh-conf.patch
17new file mode 100644
18index 0000000..b959a67
19--- /dev/null
20+++ b/debian/patches/fix-outdated-info-ssh-conf.patch
21@@ -0,0 +1,54 @@
22+Description: Fix outdated information in ssh_config.5
23+ The release of OpenSSH 8.2 has removed 'ssh-rsa' from
24+ the default list of CACertificateAlgorithms.
25+ .
26+ openssh (1:8.2p1-4) unstable; urgency=medium
27+ .
28+ * Add /etc/ssh/ssh_config.d/ to openssh-client.
29+ * Add /etc/ssh/sshd_config.d/ to openssh-server (closes: #952427).
30+ * Install ssh-sk-helper even on non-Linux architectures, though it will
31+ need an external middleware library in those cases.
32+Author: Colin Watson <cjwatson@debian.org>
33+Bug-Debian: https://bugs.debian.org/952427
34+
35+---
36+The information above should follow the Patch Tagging Guidelines, please
37+checkout http://dep.debian.net/deps/dep3/ to learn about the format. Here
38+are templates for supplementary fields that you might want to add:
39+
40+Origin: upstream, https://github.com/openssh/openssh-portable/commit/53ea05e09b04fd7b6dea66b42b34d65fe61b9636
41+Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/openssh/+bug/1871465
42+Last-Update: 2022-07-26
43+
44+--- openssh-8.2p1.orig/ssh_config.5
45++++ openssh-8.2p1/ssh_config.5
46+@@ -390,8 +390,11 @@ Specifies which algorithms are allowed f
47+ by certificate authorities (CAs).
48+ The default is:
49+ .Bd -literal -offset indent
50+-ecdsa-sha2-nistp256,ecdsa-sha2-nistp384,ecdsa-sha2-nistp521,
51+-ssh-ed25519,rsa-sha2-512,rsa-sha2-256,ssh-rsa
52++ssh-ed25519,ecdsa-sha2-nistp256,
53++ecdsa-sha2-nistp384,ecdsa-sha2-nistp521,
54++sk-ssh-ed25519@openssh.com,
55++sk-ecdsa-sha2-nistp256@openssh.com,
56++rsa-sha2-512,rsa-sha2-256
57+ .Ed
58+ .Pp
59+ .Xr ssh 1
60+--- openssh-8.2p1.orig/sshd_config.5
61++++ openssh-8.2p1/sshd_config.5
62+@@ -408,8 +408,11 @@ Specifies which algorithms are allowed f
63+ by certificate authorities (CAs).
64+ The default is:
65+ .Bd -literal -offset indent
66+-ecdsa-sha2-nistp256,ecdsa-sha2-nistp384,ecdsa-sha2-nistp521,
67+-ssh-ed25519,rsa-sha2-512,rsa-sha2-256,ssh-rsa
68++ssh-ed25519,ecdsa-sha2-nistp256,
69++ecdsa-sha2-nistp384,ecdsa-sha2-nistp521,
70++sk-ssh-ed25519@openssh.com,
71++sk-ecdsa-sha2-nistp256@openssh.com,
72++rsa-sha2-512,rsa-sha2-256
73+ .Ed
74+ .Pp
75+ Certificates signed using other algorithms will not be accepted for
76diff --git a/debian/patches/series b/debian/patches/series
77index 8c1046a..007b2e5 100644
78--- a/debian/patches/series
79+++ b/debian/patches/series
80@@ -23,3 +23,4 @@ debian-config.patch
81 restore-authorized_keys2.patch
82 conch-old-privkey-format.patch
83 revert-ipqos-defaults.patch
84+fix-outdated-info-ssh-conf.patch

Subscribers

People subscribed via source and target branches