Merge ~michal-maloszewski99/ubuntu/+source/backuppc:fix-canonical-path-ping6 into ubuntu/+source/backuppc:ubuntu/bionic-devel

Proposed by Michał Małoszewski
Status: Merged
Approved by: git-ubuntu bot
Approved revision: not available
Merged at revision: 0a07813ef29d47f5ebacd16da862ce3d1385912f
Proposed branch: ~michal-maloszewski99/ubuntu/+source/backuppc:fix-canonical-path-ping6
Merge into: ubuntu/+source/backuppc:ubuntu/bionic-devel
Diff against target: 30 lines (+9/-2)
2 files modified
debian/changelog (+6/-0)
debian/rules (+3/-2)
Reviewer Review Type Date Requested Status
git-ubuntu bot Approve
Sergio Durigan Junior (community) Approve
Christian Ehrhardt  Pending
Canonical Server Reporter Pending
Canonical Server Core Reviewers Pending
Review via email: mp+427945@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Michał Małoszewski (michal-maloszewski99) wrote :

I am about to finish SRU bug report and push a package with changes to PPA.

Revision history for this message
Michał Małoszewski (michal-maloszewski99) wrote :
Revision history for this message
Michał Małoszewski (michal-maloszewski99) wrote :
Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Thanks for the MP, Michał.

This is not correct because there is a missing backslash on d/rules, which causes the new configure option to be ignored. I would strongly recommend you to install the package from your PPA inside a Bionic container and double check that the fix is indeed there; you will notice that Ping6Path is still empty.

review: Needs Fixing
Revision history for this message
Michał Małoszewski (michal-maloszewski99) wrote :

> Thanks for the MP, Michał.
>
> This is not correct because there is a missing backslash on d/rules, which
> causes the new configure option to be ignored. I would strongly recommend you
> to install the package from your PPA inside a Bionic container and double
> check that the fix is indeed there; you will notice that Ping6Path is still
> empty.
Done

Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Thanks. Uploaded:

$ dput backuppc_3.3.1-4ubuntu1.1_source.changes
Trying to upload package to ubuntu
Checking signature on .changes
gpg: /home/sergio/work/backuppc/backuppc_3.3.1-4ubuntu1.1_source.changes: Valid signature from 106DA1C8C3CBBF14
Checking signature on .dsc
gpg: /home/sergio/work/backuppc/backuppc_3.3.1-4ubuntu1.1.dsc: Valid signature from 106DA1C8C3CBBF14
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading backuppc_3.3.1-4ubuntu1.1.dsc: done.
  Uploading backuppc_3.3.1-4ubuntu1.1.diff.gz: done.
  Uploading backuppc_3.3.1-4ubuntu1.1_source.buildinfo: done.
  Uploading backuppc_3.3.1-4ubuntu1.1_source.changes: done.
Successfully uploaded packages.

review: Approve
Revision history for this message
git-ubuntu bot (git-ubuntu-bot) wrote :

Approvers: sergiodj, michal-maloszewski99
Uploaders: sergiodj
MP auto-approved

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 825006c..e9b5834 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,9 @@
6+backuppc (3.3.1-4ubuntu1.1) bionic; urgency=medium
7+
8+ * d/rules: Specify canonical path to ping6 (LP: #782890)
9+
10+ -- Michal Maloszewski <michal.maloszewski@canonical.com> Fri, 05 Aug 2022 14:37:19 +0200
11+
12 backuppc (3.3.1-4ubuntu1) zesty; urgency=low
13
14 * Merge from Debian unstable. Remaining changes:
15diff --git a/debian/rules b/debian/rules
16index 6945b92..e8165ac 100755
17--- a/debian/rules
18+++ b/debian/rules
19@@ -64,8 +64,9 @@ install: build
20 --bin-path rsync=/usr/bin/rsync --bin-path ping=/bin/ping \
21 --bin-path df=/bin/df --bin-path ssh=/usr/bin/ssh \
22 --bin-path sendmail=/usr/sbin/sendmail --bin-path hostname=/bin/hostname \
23- --bin-path par2=/usr/bin/par2 --bin-path gzip=/bin/gzip --bin-path bzip2=/bin/bzip2
24-
25+ --bin-path par2=/usr/bin/par2 \
26+ --bin-path gzip=/bin/gzip --bin-path bzip2=/bin/bzip2 \
27+ --bin-path ping6=/bin/ping6
28 pod2man --section=8 --center="BackupPC manual" doc/BackupPC.pod backuppc.8
29 perl -e "s/.IX Title.*/.SH NAME\nbackuppc \\- BackupPC manual/g" -p -i.tmp backuppc.8
30 mv -f debian/backuppc/usr/share/backuppc/cgi-bin/* debian/backuppc/usr/share/backuppc/lib/realindex.cgi

Subscribers

People subscribed via source and target branches